Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for issue 5997 failure and success conditions. #13525

Merged
merged 4 commits into from
Apr 18, 2014

Conversation

Ryman
Copy link
Contributor

@Ryman Ryman commented Apr 15, 2014

Closes #5997.

// option. This file may not be copied, modified, or distributed
// except according to those terms.

// error-pattern: missing type param `Z` in the substitution of `Z`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like there's still a bug lurking, since this error message seems wrong/poor/useless. (Especially since the use of an error-pattern implies that it's not associated with the enum E { V(Z) } line below?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check latest commit, I shouldn't have ignored the original fishiness :)

@Ryman
Copy link
Contributor Author

Ryman commented Apr 17, 2014

Had to distinguish another error (forwardly declared type params) to get this clean without confusing/unhelpful errors.

bors added a commit that referenced this pull request Apr 18, 2014
@bors bors closed this Apr 18, 2014
@bors bors merged commit f829d20 into rust-lang:master Apr 18, 2014
notriddle pushed a commit to notriddle/rust that referenced this pull request Nov 10, 2022
…e, r=jonas-schievink

feat: show signature help when calling generic types implementing `FnOnce`

This queries chalk for the `FnOnce` impl of callees and takes argument and return types from there, making generic `Callable`s available to the IDE. This makes signature help work for them, and potentially allows other features to take generic callables into account in the future.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 18, 2024
Changelog for Clippy 1.82 ✈️

```
Roses are red,
Violets are blue,
EuroRust in Austria,
    RustConf in Canada.
```

---

### The cat of this release is *Racka*:

<img height=500 src="https://github.com/user-attachments/assets/e5e3cc95-6fc3-4214-aab0-4f26e0967ae5" alt="The cats of this Clippy release" />

Cats for the next release can be nominated in the comments :D

---

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using enclosing function's type parameter in enum definition yields ICE instead of error
4 participants