Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Un-ignore some float tests on windows #13529

Closed
wants to merge 1 commit into from
Closed

std: Un-ignore some float tests on windows #13529

wants to merge 1 commit into from

Conversation

alexcrichton
Copy link
Member

These were fixed in the upgrade from mingw32 to mingw64.

Closes #8663

@alexcrichton
std: Un-ignore some float tests on windows
725f276 
These were fixed in the upgrade from mingw32 to mingw64.

Closes rust-lang#8663
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Apr 16, 2014
@alexcrichton
Test fixes from the rollup
6571fb0 
Closes rust-lang#13546 (workcache: Don't assume gcc exists on all platforms)
Closes rust-lang#13545 (std: Remove pub use globs)
Closes rust-lang#13530 (test: Un-ignore smallest-hello-world.rs)
Closes rust-lang#13529 (std: Un-ignore some float tests on windows)
Closes rust-lang#13528 (green: Add a helper macro for booting libgreen)
Closes rust-lang#13526 (Remove RUST_LOG="::help" from the docs)
Closes rust-lang#13524 (dist: Make Windows installer uninstall first. Closes rust-lang#9563)
Closes rust-lang#13521 (Change AUTHORS section in the man pages)
Closes rust-lang#13519 (Update GitHub's Rust projects page.)
Closes rust-lang#13518 (mk: Change windows to install from stage2)
Closes rust-lang#13516 (liburl doc: insert missing hyphen)
Closes rust-lang#13514 (rustdoc: Better sorting criteria for searching.)
Closes rust-lang#13512 (native: Fix a race in select())
Closes rust-lang#13506 (Use the unsigned integer types for bitwise intrinsics.)
Closes rust-lang#13502 (Add a default impl for Set::is_superset)
@alexcrichton alexcrichton deleted the windows-floats branch April 16, 2014 08:00
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2024
@bors
Auto merge of rust-lang#16742 - alibektas:13529/source_root_tree, r=V…
a1fda64 
…eykril

internal: Implement parent-child relation for `SourceRoot`s

This commit adds the said relation by keeping a map of type `FxHashMap<SourceRootId,Option<SourceRootId>>` inside the `GlobalState`. Its primary use case is reading `rust-analyzer.toml`(rust-lang#13529)  files that can be placed in every local source root. As a config will be found by traversing this "tree" we need the parent information for every local source root. This commit omits defining this relation for library source roots entirely.
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
@bors
Auto merge of rust-lang#16639 - alibektas:13529/config_restruct, r=Ve…
58eb1f0 
…ykril

internal : redesign rust-analyzer::config

This PR aims to cover the infrastructural requirements for the `rust-analyzer.toml` ( rust-lang#13529 ) issue. This means, that

1. We no longer have a single config base. The once single `ConfigData` has been divided into 4 : A tree of `.ratoml` files, a set of configs coming from the client ( this is what was called before the `CrateData` except that now values do not default to anything when they are not defined) , a set of configs that will reflect what the contents of a `ratoml` file defined in user's config directory ( e.g `~/.config/rust-analyzer/.rust-analyzer.toml` and finally a tree root that is populated by default values only.
2. Configs have also been divided into 3 different blocks : `global` , `local` , `client`. The current status of a config may change until rust-lang#13529 got merged.

Once again many thanks to `@cormacrelf` for doing all the serde work.
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
@bors
Auto merge of rust-lang#16639 - alibektas:13529/config_restruct, r=Ve…
1179c3e 
…ykril

internal : redesign rust-analyzer::config

This PR aims to cover the infrastructural requirements for the `rust-analyzer.toml` ( rust-lang#13529 ) issue. This means, that

1. We no longer have a single config base. The once single `ConfigData` has been divided into 4 : A tree of `.ratoml` files, a set of configs coming from the client ( this is what was called before the `CrateData` except that now values do not default to anything when they are not defined) , a set of configs that will reflect what the contents of a `ratoml` file defined in user's config directory ( e.g `~/.config/rust-analyzer/.rust-analyzer.toml` and finally a tree root that is populated by default values only.
2. Configs have also been divided into 3 different blocks : `global` , `local` , `client`. The current status of a config may change until rust-lang#13529 got merged.

Once again many thanks to `@cormacrelf` for doing all the serde work.
lnicola pushed a commit to lnicola/rust that referenced this pull request Jun 23, 2024
@bors
Auto merge of rust-lang#17058 - alibektas:13529/ratoml, r=Veykril
a9f0e20 
feat: TOML based config for rust-analyzer

> Important
>
> We don't promise _**any**_ stability with this feature yet, any configs exposed may be removed again, the grouping may change etc.

# TOML Based Config for RA

This PR ( addresses rust-lang#13529 and this is a follow-up PR on rust-lang#16639 ) makes rust-analyzer configurable by configuration files called `rust-analyzer.toml`. Files **must** be named `rust-analyzer.toml`. There is not a strict rule regarding where the files should be placed, but it is recommended to put them near a file that triggers server to start (i.e., `Cargo.{toml,lock}`, `rust-project.json`).

## Configuration Types

Previous configuration keys are now split into three different classes.

1. Client keys: These keys only make sense when set by the client (e.g., by setting them in `settings.json` in VSCode). They are but a small portion of this list. One such example is `rust_analyzer.files_watcher`, based on which either the client or the server will be responsible for watching for changes made to project files.
2. Global keys: These keys apply to the entire workspace and can only be set on the very top layers of the hierarchy. The next section gives instructions on which layers these are.
3. Local keys: Keys that can be changed for each crate if desired.

### How Am I Supposed To Know If A Config Is Gl/Loc/Cl ?

rust-lang#17101

## Configuration Hierarchy

There are 5 levels in the configuration hierarchy. When a key is searched for, it is searched in a bottom-up depth-first fashion.

### Default Configuration

**Scope**: Global, Local, and Client

This is a hard-coded set of configurations. When a configuration key could not be found, then its default value applies.

### User configuration

**Scope**: Global, Local

If you want your configurations to apply to **every** project you have, you can do so by setting them in your `$CONFIG_DIR/rust-analyzer/rust-analyzer.toml` file, where `$CONFIG_DIR` is :

| Platform | Value                                 | Example                                  |
| ------- | ------------------------------------- | ---------------------------------------- |
| Linux   | `$XDG_CONFIG_HOME` or `$HOME`/.config | /home/alice/.config                      |
| macOS   | `$HOME`/Library/Application Support   | /Users/Alice/Library/Application Support |
| Windows | `{FOLDERID_RoamingAppData}`           | C:\Users\Alice\AppData\Roaming           |

### Client configuration

**Scope**: Global, Local, and Client

Previously, the only way to configure rust-analyzer was to configure it from the settings of the Client you are using. This level corresponds to that.

> With this PR, you don't need to port anything to benefit from new features. You can continue to use your old settings as they are.

### Workspace Root Configuration

**Scope**: Global, Local

Rust-analyzer already used the path of the workspace you opened in your Client. We used this information to create a configuration file that won't affect your other projects and define global level configurations at the same time.

### Local Configuration

**Scope**: Local

You can also configure rust-analyzer on a crate level. Although it is not an error to define global ( or client ) level keys in such files, they won't be taken into consideration by the server. Defined local keys will affect the crate in which they are defined and crate's descendants. Internally, a Rust project is split into what we call `SourceRoot`s. This, although with exceptions, is equal to splitting a project into crates.

> You may choose to have more than one `rust-analyzer.toml` files within a `SourceRoot`, but among them, the one closer to the project root will be
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 18, 2024
@bors
Auto merge of rust-lang#13534 - GnomedDev:fix-large-stack-arrays-nest…
05f3793 
…ed-item, r=flip1995

Fix large_stack_arrays triggering when nesting const items

Fixes rust-lang#13529.

r? `@flip1995`

changelog: [`large_stack_arrays`]: No longer triggers in static/const context when using nested items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

{f32,f64,float}::tests::test_abs_sub unit tests in libstd fail on Windows
2 participants
@alexcrichton @brson