Implement RFC #18 #14479
Closed
Implement RFC #18 #14479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of RFC 18, struct layout is undefined. Opting into a C-compatible struct layout is now down with #[repr(C)]. For consistency, specifying a packed layout is now also down with #[repr(packed)]. Both can be specified. [breaking-change]
| @@ -544,7 +544,7 @@ mod imp { | |||
| static IMAGE_FILE_MACHINE_IA64: libc::DWORD = 0x0200; | |||
| static IMAGE_FILE_MACHINE_AMD64: libc::DWORD = 0x8664; | |||
|
|
|||
| #[packed] | |||
| #[repr(packed)] | |||
There was a problem hiding this comment.
Ah yes, stupid cfg'd code!
|
@alexcrichton at this point I'd rather just overhaul the ctypes lint to be more precise, and done after trans. Right now it handwaves away things like generic structs. I feel like: should be a warning where T is not |
|
At minimum you may want to deal with pointer types to structs, as those are probably the most common way of dealing with FFI structs. A fancier lint could come later. |
|
Closing due to inactivity, but feel free to reopen with a rebase! |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
Desugar async fn completely fix rust-lang#14479
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14309.
Extends the ctypes lint to warn when a struct not annotated with
#[repr(C)] is used in an FFI function.