std: Add some implementation of common traits #15564
Conversation
alexcrichton
commented
Jul 10, 2014
alexcrichton
commented
- semver::Version is now Eq, Ord, and Hash
- Path is now PartialOrd and Ord
| @@ -79,7 +79,7 @@ impl fmt::Show for Identifier { | |||
|
|
|||
|
|
|||
| /// Represents a version number conforming to the semantic versioning scheme. | |||
| #[deriving(Clone)] | |||
| #[deriving(Clone, Hash, Eq)] | |||
There was a problem hiding this comment.
Should Hash match PartialEq/Ord? i.e. there are Versions that are equal under either of those two traits for but which have different hashes, due to the build metadata.
|
cc #15294 |
|
Updated with feedback. |
| #[allow(missing_doc)] | ||
| pub enum Identifier { | ||
| Numeric(uint), | ||
| AlphaNumeric(String) | ||
| } | ||
|
|
||
| impl cmp::PartialOrd for Identifier { | ||
| #[inline] | ||
| fn partial_cmp(&self, other: &Identifier) -> Option<Ordering> { |
There was a problem hiding this comment.
It seems important to preserve this exact ordering logic here to be consistent with the semver spec. Are we sure we want to depend on the internals of deriving for that?
There was a problem hiding this comment.
This looks pretty straightforward and I think that we should be able to rely on the order for an enum as "smallest listed first" as other types like Option depend on it as well.
There was a problem hiding this comment.
I think it would be eminently sensible for us to define #[deriving] like that (modulo explicit discriminants #15523): if someone wants to get a super-optimised comparison that isn't necessarily the declaration-order, they can implement the trait manually.
- semver::Version is now Eq, Ord, and Hash - Path is now PartialOrd and Ord
- semver::Version is now Eq, Ord, and Hash - Path is now PartialOrd and Ord
…ubcrates-rustfmt-toml-with-custom-command, r=Veykril internal: use current folder's `rustfmt.toml` with all rustfmt configurations ## Introduction Resolves rust-lang/rust-analyzer#15540. I moved the `chdir` functionality outside of the `match` to ensure that this functionality wouldn’t fall through again. As part of this PR, I also changed `from_proto::file_range` to accept a `TextDocumentIdentifier` by reference instead of by value, but I can undo this change if desired. ## Testing I added a `rustfmt.toml` will the contents below at `crates/rust-analyzer/rustfmt.toml`: ```toml reorder_modules = false use_small_heuristics = "Max" # this is the only difference from the `rustfmt.toml` at the root of the repo tab_spaces = 8 ``` In addition, I've also added `"rust-analyzer.rustfmt.overrideCommand": ["rustfmt"]` to my VS Code configuration. With the above changes, saving `crates/rust-analyzer/src/handlers/request.rs` results in 8-space indentation. Meanwhile, saving `crates/toolchain/src/lib.rs` _does not_ result in any formatting changes.
