Implement RFC #43 #16102
Merged
Implement RFC #43 #16102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In a way, this is kind of a hack to make the borrow checker stupider than it actually is, but I don't know of a better way to do this while supporting |
|
I will review but it is difficult this week due to TC39. |
| @@ -28,6 +28,57 @@ use util::ppaux::Repr; | |||
|
|
|||
| use std::rc::Rc; | |||
|
|
|||
| // FIXME: These functions are intended to allow the borrow checker to be less | |||
There was a problem hiding this comment.
Can you put an issue # here?
|
Looks good modulo that one nit. |
added 4 commits
July 30, 2014 13:36
Remove the ability of the borrow checker to determine that repeated dereferences of a Box<T> refer to the same memory object. This will usually require one of two workarounds: 1) The interior of a Box<T> will sometimes need to be moved / borrowed into a temporary before moving / borrowing individual derived paths. 2) A `ref x` pattern will have to be replaced with a `box ref x` pattern. Fixes #16094. [breaking-change]
|
Updated to address @pcwalton's nit. |
bors
added a commit
that referenced
this pull request
Aug 1, 2014
This removes the ability of the borrow checker to determine that repeated dereferences of a Box<T> refer to the same memory object.
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2012 The Rust Project Developers. See the COPYRIGHT | |||
| // Copyright 2014 The Rust Project Developers. See the COPYRIGHT | |||
There was a problem hiding this comment.
Shouldn't the year be 2012-2014?
This was referenced Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the ability of the borrow checker to determine that repeated dereferences of a Box refer to the same memory object.
update: document RFC 130; PR: rust-lang/rfcs#130