Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librustc: Stop assuming that implementations and traits only contain #16286

Merged
merged 1 commit into from
Aug 14, 2014

Conversation

pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Aug 6, 2014

methods.

This paves the way to associated items by introducing an extra level of
abstraction ("impl-or-trait item") between traits/implementations and
methods. This new abstraction is encoded in the metadata and used
throughout the compiler where appropriate.

There are no functional changes; this is purely a refactoring.

r? @nick29581

@pcwalton
Copy link
Contributor Author

pcwalton commented Aug 7, 2014

r? @nikomatsakis

@nikomatsakis
Copy link
Contributor

r+

@sfackler
Copy link
Member

sfackler commented Aug 8, 2014

Needs a rebase

@nrc
Copy link
Member

nrc commented Aug 9, 2014

Sorry I missed the review ping - gmail spam-filtered the email for me :-(

methods.

This paves the way to associated items by introducing an extra level of
abstraction ("impl-or-trait item") between traits/implementations and
methods. This new abstraction is encoded in the metadata and used
throughout the compiler where appropriate.

There are no functional changes; this is purely a refactoring.
bors added a commit that referenced this pull request Aug 14, 2014
…ikomatsakis

methods.

This paves the way to associated items by introducing an extra level of
abstraction ("impl-or-trait item") between traits/implementations and
methods. This new abstraction is encoded in the metadata and used
throughout the compiler where appropriate.

There are no functional changes; this is purely a refactoring.

r? @nick29581
@bors bors closed this Aug 14, 2014
@bors bors merged commit 9907fa4 into rust-lang:master Aug 14, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Aug 29, 2024
…ebold

internal: Be more resilient to bad language item definitions in binop inference

Fixes rust-lang#16287
Fixes rust-lang#16286

There's one more in `write_fn_trait_method_resolution`, but I'm not sure if it won't cause further problems in `infer_closures`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants