Add tests for a few A-needstest issues #17199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexcrichton Hey, sorry about that, tidy issues. Can we try again? |
|
We can indeed! |
bors
added a commit
that referenced
this pull request
Sep 15, 2014
ghost
deleted the
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jul 11, 2024
Use proper `ImplTraits` in `insert_inference_vars_for_impl_trait` Fixes rust-lang#17199 and fixes rust-lang#17403 In the previous implementation, I passed `rpits` as a function parameter and used `idx` of `ImplTraitId` for indexing `ImplTrait`. https://github.com/rust-lang/rust-analyzer/blob/4e836c622a7bdab41be8e82733dd9fe40af128b2/crates/hir-ty/src/infer.rs#L881-L887 But that `idx` is rather a "local" one, so in the cases like mentioned issues, the async function that can be expanded roughly as ```rust type TypeAlias = impl Something; fn expanded_async() -> impl Future<Output = TypeAlias> { ... } ``` there are two bundles of `ImplTraits`; one for the `impl Future` and the other one for `TypeAlias`. So using `idx` with `rpits` returns `ImplTrait` for `impl Future` even if we are asking for `TypeAlias` and this caused a stack overflow. This PR is a fix for that implementation miss 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7813.
Closes #10902.
Closes #11374.
Closes #11714.
Closes #12920.
Closes #13202.
Closes #13624.
Closes #14039.
Closes #15730.
Closes #15783.