DSTify BytesContainer #18463
Merged
DSTify BytesContainer #18463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I'm fine with removing |
|
Agreed with @alexcrichton. Can you update with the proposed change for |
|
Addressed Path ergonomics and squashed. @aturon re-r? |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 31, 2014
|
Rebased. @alexcrichton or @aturon re-r? |
|
@aturon / @alexcrichton Could you tell bors to retry? The previous attempt failed because one of the bots was continuously failing an udp-related test. But, I think the bots are properly working now. |
|
@japaric done! |
bors
added a commit
that referenced
this pull request
Nov 3, 2014
- The `BytesContainer::container_into_owned_bytes` method has been removed
- Methods that used to take `BytesContainer` implementors by value, now take them by reference. In particular, this breaks some uses of Path:
``` rust
Path::new("foo") // Still works
path.join(another_path) -> path.join(&another_path)
```
[breaking-change]
---
Re: `container_into_owned_bytes`, I've removed it because
- Nothing in the whole repository uses it
- Takes `self` by value, which is incompatible with unsized types (`str`)
The alternative to removing this method is to split `BytesContainer` into `BytesContainer for Sized?` and `SizedBytesContainer: BytesContainer + Sized`, where the second trait only contains the `container_into_owned_bytes` method. I tried this alternative [in another branch](https://github.com/japaric/rust/commits/bytes) and it works, but it seemed better not to create a new trait for an unused method.
Re: Breakage of `Path` methods
We could use the idea that @alexcrichton proposed in #18457 (add blanket `impl BytesContainer for &T where T: BytesContainer` + keep taking `T: BytesContainer` by value in `Path` methods) to avoid breaking any code.
r? @aturon
cc #16918
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BytesContainer::container_into_owned_bytesmethod has been removedBytesContainerimplementors by value, now take them by reference. In particular, this breaks some uses of Path:[breaking-change]
Re:
container_into_owned_bytes, I've removed it becauseselfby value, which is incompatible with unsized types (str)The alternative to removing this method is to split
BytesContainerintoBytesContainer for Sized?andSizedBytesContainer: BytesContainer + Sized, where the second trait only contains thecontainer_into_owned_bytesmethod. I tried this alternative in another branch and it works, but it seemed better not to create a new trait for an unused method.Re: Breakage of
PathmethodsWe could use the idea that @alexcrichton proposed in #18457 (add blanket
impl BytesContainer for &T where T: BytesContainer+ keep takingT: BytesContainerby value inPathmethods) to avoid breaking any code.r? @aturon
cc #16918