Improve quality of String#to_slice() deprecation message #21157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
steveklabnik
force-pushed
the
deprecation
branch
from
bc1a3bc
to
bd24297
Compare
| @@ -1150,7 +1150,7 @@ mod traits { | |||
|
|
|||
| /// Any string that can be represented as a slice | |||
| #[unstable = "Instead of taking this bound generically, this trait will be \ | |||
| replaced with one of slicing syntax, deref coercions, or \ | |||
| replaced with one of slicing syntax (&foo[]), deref coercions (&*foo), or \ | |||
There was a problem hiding this comment.
This deref coercions is actually referring to this RFC rather than existing syntax. It may be worth calling it out a little more perhaps.
There was a problem hiding this comment.
Hmm yeah. At the same time, don't want to make it too verbose...
There was a problem hiding this comment.
Perhaps this could avoid using (&*foo) explicitly? Eventually it'll in theory just be &foo to coerce to &str from &String.
steveklabnik
force-pushed
the
deprecation
branch
from
bd24297
to
29e5d8d
Compare
|
@alexcrichton updated to remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.