Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement .. syntax for RangeFull as expression #21947

Merged
merged 2 commits into from
Feb 6, 2015

Conversation

bluss
Copy link
Member

@bluss bluss commented Feb 4, 2015

Implement step 1 of rust-lang/rfcs#702

Allows the expression .. (without either endpoint) in general, can be
used in slicing syntax &expr[..] where we previously wrote &expr[].

The old syntax &expr[] is not yet removed or warned for, but will be removed later.

Allows the expression `..` (without either endpoint) in general, can be
used in slicing syntax `&expr[..]` where we previously wrote `&expr[]`.

The old syntax &expr[] is not yet removed or warned for.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@bluss
Copy link
Member Author

bluss commented Feb 4, 2015

We need a snapshot before we can implement the next step of converting all uses of &expr[] into &expr[..].

I don't know if it's too weird to add the deprecation message commented out like that, I could remove that code entirely.

@brson
Copy link
Contributor

brson commented Feb 4, 2015

@bors: r+ 7523914

@bors
Copy link
Contributor

bors commented Feb 5, 2015

⌛ Testing commit 7523914 with merge 5e306de...

@bors
Copy link
Contributor

bors commented Feb 5, 2015

💔 Test failed - auto-mac-64-opt

Update tests to change all `&expr[]` to `&expr[..]` to make sure pretty printing
passes.
@bluss
Copy link
Member Author

bluss commented Feb 5, 2015

Thanks for the review! I didn't think about the pretty tests, I've fixed that now.

@brson
Copy link
Contributor

brson commented Feb 6, 2015

@bors: r+ 7d52

bors added a commit that referenced this pull request Feb 6, 2015
Implement step 1 of rust-lang/rfcs#702

Allows the expression `..` (without either endpoint) in general, can be
used in slicing syntax `&expr[..]` where we previously wrote `&expr[]`.

The old syntax &expr[] is not yet removed or warned for.
@bors
Copy link
Contributor

bors commented Feb 6, 2015

⌛ Testing commit 7d527fa with merge 715f9a5...

@bors bors merged commit 7d527fa into rust-lang:master Feb 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants