Validate inline attribute arguments #22490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nick29581 (rust_highfive has picked a reviewer for you, use r? to override) |
|
Perhaps |
|
@bors: r+ 7dc750b Thanks! |
|
I took the liberty of adding |
|
Ah @nagisa pointed out on IRC that this only validates the contents of |
|
(needs rebase) |
|
Rebased. Sigh… on old master. Rebasing take 2. |
|
@bors: r=alexcrichton nagisa@c9d0967 |
|
🙀 You have the wrong number! Please try again with |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly relevant issue: #2809
Currently
#[inline()]is an alias for#[inline], not sure whether we want to do anything different here (warning maybe?).