don't leak file descriptors <3 #22678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
Fixes #19028 |
| // Note that errors are ignored when closing a file descriptor. The reason for | ||
| // this is that if an error occurs we don't actually know if the file descriptor | ||
| // was closed or not, and if we retried (for something like EINTR), we might close | ||
| // another valid file descriptor (opened after we closed ours. |
There was a problem hiding this comment.
Could you add the missing ) while you're here?
|
While I agree that we should land this soon, I do not believe that we can do so currently due to the reliance of In the interest of keeping the queue relatively clear I'm going to close this for now but we can certainly land once |
|
I hope #22797 can help to merge this PR. |
|
cc #12148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge before old_io has been removed.
cc @alexcrichton @aturon