Remove integer suffixes where the types in compiled code are identical. #22994
Conversation
eddyb
force-pushed
the
unsuffix-ints-good
branch
from
92cc07c
to
35f9f1b
Compare
|
☔ The latest upstream changes (presumably #22995) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Nice! From what I can tell there are no substantial changes other than removing integer suffixes, so r=me whenever this is ready to go. |
eddyb
force-pushed
the
unsuffix-ints-good
branch
from
35f9f1b
to
c414de4
Compare
|
r? @alexcrichton @bors r=alexcrichton |
|
@bors r=eddyb c414de4 |
|
☔ The latest upstream changes (presumably #23002) made this pull request unmergeable. Please resolve the merge conflicts. |
eddyb
force-pushed
the
unsuffix-ints-good
branch
from
c414de4
to
b67f501
Compare
|
@bors r=alexcrichton b67f501 |
|
⌛ Testing commit b67f501 with merge 8b7c249... |
|
💔 Test failed - auto-mac-32-opt |
| (|| Box::new(*[0_usize].as_slice()))(); | ||
| //~^ ERROR the trait `core::marker::Sized` is not implemented for the type `[usize]` | ||
| (|| Box::new(*[0].as_slice()))(); | ||
| //~^ ERROR the trait `core::marker::Sized` is not implemented for the type `[i32]` |
There was a problem hiding this comment.
the error message we are actually getting here is:
error: the trait
core::marker::Sizedis not implemented for the type[_]
which i admit, raises a semi-interesting question about whether we are better off applying int-fallback to our error message output (as it seems like @eddyb assumed would be done here?)
@pnkfelix well, it was |
eddyb
force-pushed
the
unsuffix-ints-good
branch
from
b67f501
to
48fba76
Compare
…chton Automatic has-same-types testing methodology can be found in rust-lang#22501. Because most of them don't work with `--pretty=typed`, compile-fail tests were manually audited. r? @aturon
…chton Automatic has-same-types testing methodology can be found in rust-lang#22501. Because most of them don't work with `--pretty=typed`, compile-fail tests were manually audited. r? @aturon
|
⌛ Testing commit 48fba76 with merge 42b86e0... |
|
💔 Test failed - auto-win-32-opt |
Automatic has-same-types testing methodology can be found in #22501.
Because most of them don't work with
--pretty=typed, compile-fail tests were manually audited.r? @aturon