Remove regex module from libunicode

[lambda-fairy]

The regex crate keeps its own tables now (rust-lang/regex#41) so we
don't need them here.

[breaking-change]

[rust-highfive]

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

[huonw]

@bors r+

[bors]

📌 Commit 963f371 has been approved by huonw

[bors]

⌛ Testing commit 963f371 with merge 0837f53...

[bors]

⛄ The build was interrupted to prioritize another pull request.

[bors]

⌛ Testing commit 963f371 with merge ff97ebf...

[bors]

⛄ The build was interrupted to prioritize another pull request.

[bors]

⌛ Testing commit 963f371 with merge 8eb857f...

[bors]

⛄ The build was interrupted to prioritize another pull request.

[bors]

⌛ Testing commit 963f371 with merge 8de10fa...

[bors]

💔 Test failed - auto-linux-64-nopt-t

[kwantam]

@lfairy good catch!

You can remove the script module to fix many of the unused code errors; this module was only used by the UNICODE_CLASSES table in the regex module. Just get rid of the ("script", scripts, []) tuple in the argument to for (name, cat, pfuns) in unicode.py.

You also will want to get rid of the other_derived variable in unicode.py, which will make unicode.py not emit the Default_Ignorable_Code_Point table; again, this was only used in the UNICODE_CLASSES table.

general_category takes some more work, since it's used in the char module, but you only need to emit N and Cc. One very straightforward way of getting the result you want here is to modify the emit_property_module function to only emit tables for categories in the emit_fn argument. Right now the behavior is to emit all tables in the tbl argument, and only emit corresponding search functions for the emit_fn argument.

[lambda-fairy]

@kwantam Thanks for the tips. I've force pushed a fixed version with your suggestions.

@huonw re-r?

[alexcrichton]

@bors: r+ 5308ac9

[bors]

⌛ Testing commit 5308ac9 with merge 5245475...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt