std::io: new ErrorKind value InvalidParam #25406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes over usages of InvalidInput where invalid parameter use likely arises from a program error. InvalidInput is dedicated to occurrences of invalid or malformed data in I/O, which may or may not be caused by deficient programming.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Cc @alexcrichton, @aturon. |
|
I prefer #25246, which I think gets at a more clear distinction. |
|
Per the comments from @alexcrichton and @aturon, I am closing this PR in favor of #25246, feel free to re-open if you disagree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rust-lang/rfcs#906.
This is an alternative to #25246, done at the suggestion by @bluss that preserving the
InvalidInputerror code in cases where invalid external data may be involved is better for minimizing impact of the change.