Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E0403, E0404, E0405, E0407, E0428 and E0433 error explanation #27084

Merged
merged 6 commits into from
Jul 22, 2015
Merged

Add E0403, E0404, E0405, E0407, E0428 and E0433 error explanation #27084

merged 6 commits into from
Jul 22, 2015

Conversation

GuillaumeGomez
Copy link
Member

Part of #24407.

Manishearth
Manishearth reviewed Jul 17, 2015
View reviewed changes
src/librustc_resolve/diagnostics.rs
// parameter in this type parameter list
```

Please verify you didn't mispell the type parameters. Example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify that none of the type params are misspelled, and rename any clashing parameters.

(missing "that"; passive voice)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here we go again haha.

@GuillaumeGomez GuillaumeGomez changed the title Add E0403 error explanation Add E0403 and E0405 error explanation Jul 17, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0403 and E0405 error explanation Add E0403, E0404 and E0405 error explanation Jul 17, 2015
@GuillaumeGomez
Copy link
Member Author

For travis actual issue, we'll have to wait that #27067 is merged.

@GuillaumeGomez GuillaumeGomez changed the title Add E0403, E0404 and E0405 error explanation Add E0403, E0404, E0405 and E0407 error explanation Jul 17, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0403, E0404, E0405 and E0407 error explanation Add E0403, E0404, E0405, E0407 and E0428 error explanation Jul 17, 2015
@GuillaumeGomez GuillaumeGomez changed the title Add E0403, E0404, E0405, E0407 and E0428 error explanation Add E0403, E0404, E0405, E0407, E0428 and E0433 error explanation Jul 17, 2015
apasel422
apasel422 reviewed Jul 17, 2015
View reviewed changes
src/librustc_resolve/diagnostics.rs
}
```

Please verify you didn't mispelled the method name and you used the good
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/mispelled/misspell/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/the good/the correct

@bors
Copy link
Contributor

bors commented Jul 18, 2015

☔ The latest upstream changes (presumably #27098) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Jul 20, 2015

☔ The latest upstream changes (presumably #27120) made this pull request unmergeable. Please resolve the merge conflicts.

@brson
Copy link
Contributor

brson commented Jul 21, 2015

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 21, 2015

📌 Commit 91cc413 has been approved by brson

@brson
Copy link
Contributor

brson commented Jul 21, 2015

@bors r-

@GuillaumeGomez this phrase is used 3 times: 'please verify you didn't misspelled'. Please change it to 'please verify you didn't misspell'.

@GuillaumeGomez
Copy link
Member Author

Fixed.

@brson
Copy link
Contributor

brson commented Jul 21, 2015

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 21, 2015

📌 Commit 2e919b4 has been approved by brson

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 21, 2015
@steveklabnik
Rollup merge of rust-lang#27084 - GuillaumeGomez:patch-2, r=brson
f114aec 
Part of rust-lang#24407.
r? @Manishearth
@steveklabnik steveklabnik mentioned this pull request Jul 21, 2015
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 21, 2015
@steveklabnik
Rollup merge of rust-lang#27084 - GuillaumeGomez:patch-2, r=brson
70eb2a1 
Part of rust-lang#24407.
r? @Manishearth
@steveklabnik steveklabnik mentioned this pull request Jul 21, 2015
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 22, 2015
@steveklabnik
Rollup merge of rust-lang#27084 - GuillaumeGomez:patch-2, r=brson
f3fdba3 
Part of rust-lang#24407.
r? @Manishearth
@steveklabnik steveklabnik mentioned this pull request Jul 22, 2015
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 22, 2015
@steveklabnik
Rollup merge of rust-lang#27084 - GuillaumeGomez:patch-2, r=brson
e6b5c96 
Part of rust-lang#24407.
r? @Manishearth
@steveklabnik steveklabnik mentioned this pull request Jul 22, 2015
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 22, 2015
@steveklabnik
Rollup merge of rust-lang#27084 - GuillaumeGomez:patch-2, r=brson
0fa220a 
Part of rust-lang#24407.
r? @Manishearth
@steveklabnik steveklabnik mentioned this pull request Jul 22, 2015
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 22, 2015
@steveklabnik
Rollup merge of rust-lang#27084 - GuillaumeGomez:patch-2, r=brson
bc4daf7 
Part of rust-lang#24407.
r? @Manishearth
@steveklabnik steveklabnik mentioned this pull request Jul 22, 2015
Merged
bors added a commit that referenced this pull request Jul 22, 2015
@bors
Auto merge of #27219 - steveklabnik:rollup, r=steveklabnik
5542830 
- Successful merges: #27084, #27127, #27131, #27140, #27146, #27147, #27151, #27154, #27155, #27156, #27157, #27158, #27163, #27164, #27166, #27167, #27170, #27175, #27183, #27201, #27202
- Failed merges: #26778
@bors bors merged commit 2e919b4 into rust-lang:master Jul 22, 2015
@GuillaumeGomez GuillaumeGomez deleted the patch-2 branch July 23, 2015 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @bors @brson @Manishearth @apasel422