Stabilize some Duration consuming methods #27655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
added
the
T-libs-api
|
👍 |
|
We might want to backport this to 1.3 as well, under the justification that these are the "super obvious" APIs to stabilize along with Duration. |
|
One thing to consider is if |
sfackler
force-pushed
the
duration-stabilization-followup
branch
2 times, most recently
from
3246dc8
to
da36099
Compare
These methods are simply the Duration consuming variants of existing stable methods that take a u32 of milliseconds.
sfackler
force-pushed
the
duration-stabilization-followup
branch
from
da36099
to
1d60cb7
Compare
|
Updated to remove the |
|
I'm going to close this in favor of the FCP issue on the tracker (see more info here: #27835 (comment)). We'll tackle this towards the end of the cycle where we handle a number of FCP unstable features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are simply the Duration consuming variants of existing
stable methods that take a u32 of milliseconds.
r? @alexcrichton
Closes #27771