Add note for possible crate mismatches in type errors #28300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m two different crate of the same name (rust-lang#22750)
| self.tcx.sess.note("errrr0"); | ||
| report_path_match(exp_found.expected, exp_found.found); | ||
| }, | ||
| _ => () // FIXME(Manishearth) handle traits and stuff |
There was a problem hiding this comment.
IIRC all FIXMEs should have an associated issue
There was a problem hiding this comment.
fixed, it's the same bug (since this is only a partial fix)
|
So excited for this patch to land! The messages look good to me. |
| let report_path_match = |did1: DefId, did2: DefId| { | ||
| // Only external crates, if either is from a local | ||
| // module we could have false positives | ||
| if !(did1.is_local() || did2.is_local()) { |
There was a problem hiding this comment.
You should check that the crates are different - for example:
fn main() {
let _ = [{struct Foo; Foo}, {struct Foo; Foo}];
}The error in the above code will see the path "main::Foo" for both of the two different types.
| //~^^ NOTE Perhaps two different versions of crate `main` | ||
| a::try_bar(bar2); //~ ERROR mismatched types | ||
| //~^ HELP run | ||
| //~^^ NOTE Perhaps two different versions of crate `main` |
There was a problem hiding this comment.
You'll want to look up the crate names from the crate numbers in the DefIds (and/or find the subset of the path which refers to the extern crate item).
|
@bors r+ |
|
📌 Commit c65d338 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 9, 2015
Partially fixes #22750 I'll write a test for this when I figure out how to. r? @eddyb cc @steveklabnik
jyn514
added
the
D-crate-version-mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #22750
I'll write a test for this when I figure out how to.
r? @eddyb
cc @steveklabnik