Make fs::canonicalize work on directories on Windows #28729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Thanks! Could you add a comment as to why this flag is being added, as well as a test? I think that making a junction may be difficult due to permissions, but perhaps it could call canonicalize on a path to just a normal directory? |
Signed-off-by: Peter Atashian <[email protected]>
retep998
force-pushed
the
canonical-dir
branch
from
014aed9
to
6b9b2ee
Compare
|
Added a comment and a test. |
bors
added a commit
that referenced
this pull request
Sep 30, 2015
brson
added
the
relnotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #27706