Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LLVM fork to include a backported fix for broken debug locations #29144

Merged
merged 1 commit into from
Oct 19, 2015
Merged

Update LLVM fork to include a backported fix for broken debug locations #29144

merged 1 commit into from
Oct 19, 2015

Conversation

dotdash
Copy link
Contributor

@dotdash dotdash commented Oct 18, 2015

Fixes #28947

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@dotdash
Copy link
Contributor Author

dotdash commented Oct 18, 2015

This allows to bootstrap with --enable-debug --enable-optimize, but tests still fail because of an ODR violation (#25270). I'm looking into that now.

@alexcrichton
Copy link
Member

@bors: r+ 92276dc

Nice find!

@bors
Copy link
Contributor

bors commented Oct 19, 2015

⌛ Testing commit 92276dc with merge 3e268f2...

bors added a commit that referenced this pull request Oct 19, 2015
@bors
Auto merge of #29144 - dotdash:llvmup, r=alexcrichton
3e268f2 
Fixes #28947
@dotdash
Copy link
Contributor Author

dotdash commented Oct 19, 2015

Gah, I totally forgot to mention that credit for identifying the commit goes to @sanxiyn and @zazdxscf. Sorry about that!

@bors
Copy link
Contributor

bors commented Oct 19, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

@bors bors merged commit 92276dc into rust-lang:master Oct 19, 2015
@bors bors mentioned this pull request Oct 19, 2015
Closed
@dotdash dotdash deleted the llvmup branch January 15, 2016 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dotdash @rust-highfive @alexcrichton @bors