doc: skipping (obvious) details here is worth making this more nice t… #31585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -528,7 +528,7 @@ impl<T> Vec<T> { | |||
| } | |||
|
|
|||
| /// Inserts an element at position `index` within the vector, shifting all | |||
| /// elements after position `i` one position to the right. | |||
| /// elements after the position to the right. | |||
There was a problem hiding this comment.
I found this sentence hard to parse, not realizing "the postion" was referencing that from the previous sentence. What about "shifting all elements after it to the right"?
|
@bors r+ |
|
📌 Commit 0352bdf has been approved by |
|
@bors rollup |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Feb 13, 2016
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 13, 2016
bors
added a commit
that referenced
this pull request
Feb 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o read