rustc: Rebase LLVM on the 3.8 release branch #31717
Conversation
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
This commit rebases our LLVM submodule on the most recent tip of the `release_38` branch of LLVM. There's been a few fixes and this notably fixes the assertion error in rust-lang#31702.
alexcrichton
force-pushed
the
llvmup2
branch
from
cc02735
to
97f7898
Compare
|
Does this also fix #29541?
|
|
I... wish I could say! On nightly, I've now lost 18GB of ram to compiling the "minimized version" and have no idea whether it was fixed or not. On stable it looks like the sample repo there compiles just fine. So maybe it's already been fixed? Not sure if I can say... |
|
Does this fix the performance regressions? |
|
@bors r+ |
|
📌 Commit 97f7898 has been approved by |
|
⌛ Testing commit 97f7898 with merge 82f30d2... |
|
I don't recall seeing any commits on behalf of LLVM related to perf improvements, so I doubt it fixes anything unfortunately :( |
|
Unfortunately this performance critical ARM patch is still not included. Oh well, that makes my Rustbuild_v7 fork really special! |
In rust-lang#31717 we rebased our LLVM fork over the 3.8 release branch, and it was thought that this fixed rust-lang#31702. The testing, however, must have been erroneous, as it unfortunately didn't fix the issue! Our MUSL nightly builders are failing from the same assertion reported in the issue, so we at least know the test case is a reproduction! I believe the failure is only happening on the MUSL nightly builders because none of the auto builders have LLVM assertions enabled, and the Linux nightly builder *does* have assertions enabled for the binaries we generate but the distcheck run doesn't test a compiler with LLVM assertions enabled.
…rson In #31717 we rebased our LLVM fork over the 3.8 release branch, and it was thought that this fixed #31702. The testing, however, must have been erroneous, as it unfortunately didn't fix the issue! Our MUSL nightly builders are failing from the same assertion reported in the issue, so we at least know the test case is a reproduction! I believe the failure is only happening on the MUSL nightly builders because none of the auto builders have LLVM assertions enabled, and the Linux nightly builder *does* have assertions enabled for the binaries we generate but the distcheck run doesn't test a compiler with LLVM assertions enabled.
This commit rebases our LLVM submodule on the most recent tip of the
release_38branch of LLVM. There's been a few fixes and this notably fixes theassertion error in #31702.
Closes #31702