Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move into_ascii_{low,upp}ercase (back) to a separate trait. #32076

Closed
wants to merge 1 commit into from
Closed

Move into_ascii_{low,upp}ercase (back) to a separate trait. #32076

wants to merge 1 commit into from

Commits on Mar 6, 2016

  1. Move into_ascii_{low,upp}ercase (back) to a separate trait. 

    Implementing `AsciiExt` for `String` and `Vec<u8>` caused a regression:
rust-lang#32074
and the `where Self: Sized` hack to have the `into_` methods in that trait
(which is also implemented for DST `str` and `[u8]`) was rather clunky.

CC rust-lang#27809
    @SimonSapin
    SimonSapin committed Mar 6, 2016
    Configuration menu
    Copy the full SHA
    f1d3c6d View commit details
    Browse the repository at this point in the history