Call str::to_owned in String::from and uninline it #32182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors: r+ 2f924980094e85164bb512577a74d3ade8378813 Nice cleanup! |
|
☔ The latest upstream changes (presumably #32112) made this pull request unmergeable. Please resolve the merge conflicts. |
String::from does not need to be inlined, it can be without it just like str::to_owned and String::clone are.
bluss
force-pushed
the
string-from-is-str-owned
branch
from
2f92498
to
ec39a76
Compare
|
rebased @bors r=alexcrichton |
|
📌 Commit ec39a76 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 13, 2016
Call str::to_owned in String::from and uninline it Call str::to_owned in String::from and uninline it These methods were already effectively equal, but now one calls the other, and neither is marked inline. String::from does not need to be inlined, it can be without it just like str::to_owned and String::clone are. Fixes #32163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call str::to_owned in String::from and uninline it
These methods were already effectively equal, but now one calls
the other, and neither is marked inline.
String::from does not need to be inlined, it can be without it just like
str::to_owned and String::clone are.
Fixes #32163