Lang item #32264
Merged
Lang item #32264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| let item_def_id = self.ast_map.local_def_id(item.id); | ||
| let span = self.ast_map.span_if_local(item_def_id).unwrap(); | ||
| span_err!(self.session, span, E0522, | ||
| "creating new item lang is forbidden: `{}`.", |
There was a problem hiding this comment.
Why not just, uh, “definition of a unknown language item”?
There was a problem hiding this comment.
Indeed, way better.
GuillaumeGomez
force-pushed
the
lang_item
branch
from
d1e79fc
to
df3baed
Compare
| The lang attribute is intended for marking special items that are built-in to | ||
| Rust itself. This includes special traits (like `Copy` and `Sized`) that affect | ||
| how the compiler behaves, as well as special functions that may be automatically | ||
| invoked (such as the handker for out-of-bounds accesses when indexing a slice). |
There was a problem hiding this comment.
Nit: s/handker/handler/
GuillaumeGomez
force-pushed
the
lang_item
branch
from
df3baed
to
b2fd882
Compare
|
Updated. |
|
@bors r+ rollup |
|
📌 Commit b2fd882 has been approved by |
hannobraun
added a commit
to hannobraun/embedded
that referenced
this pull request
Mar 24, 2016
The Rust version is now at:
```
rustc 1.9.0-nightly (0dcc413e4 2016-03-22)
```
This includes a fix for the following build error that the new version
produced:
```
src/rust_base.rs:17:1: 19:2 error: definition of an unknown language
item: `stack_exhausted`. [E0522]
src/rust_base.rs:17 pub extern fn stack_exhausted() {
src/rust_base.rs:18 panic!("Stack exhausted");
src/rust_base.rs:19 }
src/rust_base.rs:17:1: 19:2 help: run `rustc --explain E0522` to see a
detailed explanation
```
It looks like the `stack_exhausted item was removed last year:
rust-lang/rust#27338
This didn't cause an error so far, because the compiler didn't complain
about defining lang items that don't exist. This seems to have changed
in this pull request:
rust-lang/rust#32264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32033