Remove ErasedRegions from substs
#32346
Conversation
|
|
||
| /// Given the node-id of some local item that has no type | ||
| /// parameters, make a suitable "empty substs" for it. | ||
| pub fn empty_substs_for_node_id(&self, item_node_id: ast::NodeId) |
There was a problem hiding this comment.
I don't think we want this function, all callers already compute local_def_id themselves.
There was a problem hiding this comment.
Heh, so they do.
On Fri, Mar 18, 2016 at 8:59 PM, Eduard-Mihai Burtescu <
[email protected]> wrote:
In src/librustc_trans/trans/context.rs
#32346 (comment):@@ -856,6 +855,29 @@ impl<'b, 'tcx> CrateContext<'b, 'tcx> {
codegen_items.insert(cgi, TransItemState::NotPredictedButGenerated);
}
}
+
- /// Given the node-id of some local item that has no type
- /// parameters, make a suitable "empty substs" for it.
- pub fn empty_substs_for_node_id(&self, item_node_id: ast::NodeId)
I don't think we want this function, all callers already compute
local_def_id themselves.—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/rust-lang/rust/pull/32346/files/378743fd079475246589c1d4ddb7b614ab58f9cc..d8c2e42975cc77263235ea29e5ed10bbaa9bcebc#r56740326
|
r=me with that one nit fixed. |
|
Doing a crater run -- I feel like I could have easily missed a corner case. |
|
Crater run: https://gist.github.com/nikomatsakis/21a52e57ab8ec18856be Two failures, both look like inconclusive results. I will try them locally. |
|
They built locally. |
|
@bors r=eddyb |
|
📌 Commit 9b03591 has been approved by |
|
@bors r- actually, I wanted to measure rustc perf first |
|
☔ The latest upstream changes (presumably #32390) made this pull request unmergeable. Please resolve the merge conflicts. |
It no longer reads from `ast_ty_to_ty_cache`, which was very wrong. It also correctly handles higher-ranked regions.
This hack has long since outlived its usefulness; the transition to trans passing around full substitutions is basically done. Instead of `ErasedRegions`, just supply substitutions with a suitable number of `'static` entries, and invoke `erase_regions` when needed (the latter of which we already do).
nikomatsakis
force-pushed
the
no-erased-regions
branch
from
9b03591
to
c5d74be
Compare
|
@bors r=eddyb |
|
📌 Commit c5d74be has been approved by |
Remove `ErasedRegions` from substs This commit removes the `ErasedRegions` enum from `Substs`. Instead, in trans, we just generate a vector of `ReStatic` of suitable length. The goal is both general cleanup and to help pave the way for a glorious future where erasure is used in type check. r? @eddyb One concern: might be nice to do some profiling. Not sure the best way to do that. Perhaps I'll investigate running nrc's test suite locally.
This commit removes the
ErasedRegionsenum fromSubsts. Instead, in trans, we just generate a vector ofReStaticof suitable length. The goal is both general cleanup and to help pave the way for a glorious future where erasure is used in type check.r? @eddyb
One concern: might be nice to do some profiling. Not sure the best way to do that. Perhaps I'll investigate running nrc's test suite locally.