Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient trie lookup for boolean Unicode properties #33098

Merged
merged 3 commits into from
May 23, 2016

Commits on Apr 19, 2016

  1. Efficient trie lookup for boolean Unicode properties

    Replace binary search of ranges with trie lookup using leaves of
    64-bit bitmap chunks. Benchmarks suggest this is approximately 10x
    faster than the bsearch approach.
    raphlinus committed Apr 19, 2016
    Configuration menu
    Copy the full SHA
    4864e0e View commit details
    Browse the repository at this point in the history
  2. Fix wrong shift in trie_lookup_range_table

    Somehow got in my head that >> 8 was the right shift for a chunk of 64.
    Oops, sorry.
    raphlinus committed Apr 19, 2016
    Configuration menu
    Copy the full SHA
    6923bc5 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2016

  1. Add comment, reduce storage requirements

    Adds a comment which explains the trie structure, and also does a
    little arithmetic on lookup (no measurable impact, looks like modern
    CPUs do this arithmetic in parallel with the memory lookup to find the
    node) to save a bit of space. As a result, the memory impact of the
    compiled tables is within a couple hundred bytes of the old
    bsearch-range structure.
    raphlinus committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    cfaf66c View commit details
    Browse the repository at this point in the history