Improve error message about regions of function body #33212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Hmm. So the new wording is less precise -- the precise set of scopes is quite fine-grained at this point, and there is a separate scope for the "fn body" (i.e., the block itself) -- but honestly I suspect it's just fine. I'd like to overhaul this whole scheme, but this seems like an improvement. |
|
@bors r+ rollup |
|
📌 Commit 9348618 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 27, 2016
…nikomatsakis Improve error message about regions of function body "scope of parameters for functions" is harder for me to read than "scope of function body", I hope others feel the same, as in <https://play.rust-lang.org/?gist=b4df68b395b807698bd2ba98cf3d5ce3&version=stable&backtrace=0&run=1> Thank @Aatch for the help :)
bors
added a commit
that referenced
this pull request
Apr 27, 2016
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 28, 2016
…nikomatsakis Improve error message about regions of function body "scope of parameters for functions" is harder for me to read than "scope of function body", I hope others feel the same, as in <https://play.rust-lang.org/?gist=b4df68b395b807698bd2ba98cf3d5ce3&version=stable&backtrace=0&run=1> Thank @Aatch for the help :)
bors
added a commit
that referenced
this pull request
Apr 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"scope of parameters for functions" is harder for me to read than "scope of function body", I hope others feel the same, as in https://play.rust-lang.org/?gist=b4df68b395b807698bd2ba98cf3d5ce3&version=stable&backtrace=0&run=1
Thank @Aatch for the help :)