-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 14 pull requests #33376
Rollup of 14 pull requests #33376
Conversation
…cutable from 'Converting to Cargo'.
There was no span available in the cast function, but we need to infer the `x` in `x as char` to `u8`. The spans are now removed from all functions using `infer` and instead added in `eval_const_expr_partial`
The implementation mirrors the one for "constant defined here" annotation used for constant patterns in the irrefutable-pattern case. Fixes: rust-lang#23716
Was causing severe performance problems in WebRender.
This will go wrong when the constants partially result from macro expansion. Instead, use the expressions and pretty-print them as Rust code. Fixes: rust-lang#33302
Especially in cases like the one in the test file, this can blow up the docs big time if string constants in the code contain HTML. But also other constants can contain special chars (e.g. `&` as an operator in constant expressions).
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ force |
📌 Commit b34d41c has been approved by |
@bors p=20 force |
@bors force |
1 similar comment
@bors force |
⌛ Testing commit b34d41c with merge 75f98ce... |
@bors r+ force |
📌 Commit 54933f2 has been approved by |
⌛ Testing commit 54933f2 with merge 2efd47c... |
💔 Test failed - auto-win-msvc-64-opt-mir |
💔 Test failed - auto-win-gnu-32-nopt-t |
@bors: retry clean |
💔 Test failed - auto-win-gnu-32-opt |
@bors retry force |
@bors force |
💥 Test timed out |
@bors: retry force |
@bors: retry |
💔 Test failed - auto-linux-64-x-android-t |
@bors: retry |
@bors: retry force clean |
🎉🎊🙌 On May 4, 2016, 20:38 -0400, [email protected], wrote:
|
T<A=B, C>
#33343, libcore: Inlinemem::forget()
. #33357, fix built-in target detection #33363, Makefile: there is only one tidy target now #33365, rustdoc: fix inserting source code spans for constant values #33371, rustdoc: HTML-escape Rust code (from constants) #33372