Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 14 pull requests #33376

Merged
merged 23 commits into from
May 5, 2016
Merged

Rollup of 14 pull requests #33376

merged 23 commits into from
May 5, 2016

Conversation

birkenfeld and others added 14 commits April 29, 2016 21:17
There was no span available in the cast function, but we need to infer the `x` in `x as char` to `u8`.
The spans are now removed from all functions using `infer` and instead added in `eval_const_expr_partial`
The implementation mirrors the one for "constant defined here" annotation
used for constant patterns in the irrefutable-pattern case.

Fixes: rust-lang#23716
Was causing severe performance problems in WebRender.
This will go wrong when the constants partially result from macro expansion.
Instead, use the expressions and pretty-print them as Rust code.

Fixes: rust-lang#33302
Especially in cases like the one in the test file, this can blow
up the docs big time if string constants in the code contain HTML.

But also other constants can contain special chars (e.g. `&` as an
operator in constant expressions).
@rust-highfive
Copy link
Collaborator

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

@Manishearth
Copy link
Member Author

@bors r+ force

@bors
Copy link
Contributor

bors commented May 3, 2016

📌 Commit b34d41c has been approved by Manishearth

@Manishearth
Copy link
Member Author

@bors p=20 force

@Manishearth
Copy link
Member Author

@bors force

1 similar comment
@Manishearth
Copy link
Member Author

@bors force

@bors
Copy link
Contributor

bors commented May 3, 2016

⌛ Testing commit b34d41c with merge 75f98ce...

@Manishearth
Copy link
Member Author

@bors r+ force

@bors
Copy link
Contributor

bors commented May 3, 2016

📌 Commit 54933f2 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented May 3, 2016

⌛ Testing commit 54933f2 with merge 2efd47c...

@bors
Copy link
Contributor

bors commented May 3, 2016

💔 Test failed - auto-win-msvc-64-opt-mir

@bors
Copy link
Contributor

bors commented May 3, 2016

💔 Test failed - auto-win-gnu-32-nopt-t

@steveklabnik
Copy link
Member

@bors: retry clean

@bors
Copy link
Contributor

bors commented May 3, 2016

⌛ Testing commit 631e7b4 with merge f7125fc...

bors added a commit that referenced this pull request May 3, 2016
Rollup of 14 pull requests

- Successful merges: #33277, #33294, #33314, #33322, #33333, #33338, #33339, #33340, #33343, #33357, #33363, #33365, #33371, #33372
- Failed merges:
@bors
Copy link
Contributor

bors commented May 3, 2016

💔 Test failed - auto-win-gnu-32-opt

@Manishearth
Copy link
Member Author

@bors retry force

@Manishearth
Copy link
Member Author

@bors force

@bors
Copy link
Contributor

bors commented May 4, 2016

💥 Test timed out

@steveklabnik
Copy link
Member

@bors: retry force

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented May 4, 2016

⌛ Testing commit 631e7b4 with merge 1895d08...

bors added a commit that referenced this pull request May 4, 2016
Rollup of 14 pull requests

- Successful merges: #33277, #33294, #33314, #33322, #33333, #33338, #33339, #33340, #33343, #33357, #33363, #33365, #33371, #33372
- Failed merges:
@bors
Copy link
Contributor

bors commented May 4, 2016

💔 Test failed - auto-linux-64-x-android-t

@alexcrichton
Copy link
Member

@bors: retry

@alexcrichton
Copy link
Member

@bors: retry force clean

@bors
Copy link
Contributor

bors commented May 4, 2016

⌛ Testing commit 631e7b4 with merge 7a0ccc4...

bors added a commit that referenced this pull request May 4, 2016
Rollup of 14 pull requests

- Successful merges: #33277, #33294, #33314, #33322, #33333, #33338, #33339, #33340, #33343, #33357, #33363, #33365, #33371, #33372
- Failed merges:
@steveklabnik
Copy link
Member

🎉🎊🙌

On May 4, 2016, 20:38 -0400, [email protected], wrote:

Merged#33376(#33376).


You are receiving this because you commented.
Reply to this email directly orview it on GitHub(#33376 (comment))

@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.