rustdoc: Don't inline #[doc(hidden)] pub use #34232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if a `#[doc(hidden)] pub use` item is inlined the `hidden` attribute is ignored so the item can appear in the docs. By never inlining such imports, they can be stripped.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
👍 |
|
⌛ Testing commit a7c4674 with merge 3cf2eea... |
|
💔 Test failed - auto-win-gnu-64-nopt-t |
|
gcc had a |
|
@bors: retry On Mon, Jun 13, 2016 at 2:57 AM, Peter Atashian [email protected]
|
bors
added a commit
that referenced
this pull request
Jun 14, 2016
rustdoc: Don't inline #[doc(hidden)] pub use Currently if a `#[doc(hidden)] pub use` item is inlined the `hidden` attribute is ignored so the item can appear in the docs. By never inlining such imports, they can be stripped. An example in `std` is [`__OsLocalKeyInner`](https://doc.rust-lang.org/nightly/std/thread/struct.__OsLocalKeyInner.html) which clearly should not be documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a
#[doc(hidden)] pub useitem is inlined thehiddenattribute is ignored so the item can appear in the docs. By never inlining
such imports, they can be stripped.
An example in
stdis__OsLocalKeyInnerwhich clearly should not be documented.