Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code example for try! #34540

Merged
merged 1 commit into from
Jul 3, 2016
Merged

Improve code example for try! #34540

merged 1 commit into from
Jul 3, 2016

Conversation

jupp0r
Copy link
Contributor

@jupp0r jupp0r commented Jun 28, 2016

This change improves the code example for try!,
avoiding to use try! in the example code that shows
what code constructs try! can replace.

This change improves the code example for try!,
avoiding to use try! in the example code that shows
what code constructs try! can replace.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

nice catch, thank you!

@bors
Copy link
Contributor

bors commented Jun 29, 2016

📌 Commit 8f3e498 has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Jul 1, 2016

⌛ Testing commit 8f3e498 with merge 3eb3a2f...

@bors
Copy link
Contributor

bors commented Jul 1, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Fri, Jul 1, 2016 at 6:31 AM, bors [email protected] wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/1639


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#34540 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95Hq_I3yKBkftHiegnYgRl708iJbGks5qRRaUgaJpZM4JAoQS
.

@bors
Copy link
Contributor

bors commented Jul 3, 2016

⌛ Testing commit 8f3e498 with merge eebfcb8...

bors added a commit that referenced this pull request Jul 3, 2016
Improve code example for try!

This change improves the code example for try!,
avoiding to use try! in the example code that shows
what code constructs try! can replace.
@bors bors merged commit 8f3e498 into rust-lang:master Jul 3, 2016
@jupp0r jupp0r deleted the patch-1 branch July 3, 2016 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants