-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pretty-printing of lifetime bound #34547
Conversation
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
@sanxiyn Thanks for taking this on! I would prefer if we factored the code a bit more so that we didn't duplicate the lifetime-bound printing loop; you can see the other loop in the Can you try doing that instead? |
Done. |
|
||
// pp-exact | ||
|
||
fn f1<'a, 'b, 'c>(_x: &'a u32, _y: &'b u32, _z: &'c u32) where 'c: 'a + 'b { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(now that I look at it, I wonder if the right convention would be to print 'c: 'a+'b
instead of 'c: 'a + 'b
. But I'm not going to let that question hold up this PR.)
@bors r+ |
📌 Commit 3c29fc5 has been approved by |
Fix pretty-printing of lifetime bound Fix rust-lang#34527.
Fix #34527.