Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve runtest output #34551

Merged
merged 1 commit into from
Jul 2, 2016
Merged

Conversation

GuillaumeGomez
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

It now prints only unexpected errors and expected errors which weren't found
@GuillaumeGomez
Copy link
Member Author

Actually, when a test fails, runtest prints ALL the errors he got and ALL the expected errors. When you only had 1 or 2 errors, it's quite easy to see what you forgot/didn't do correctly. However, when you have like 10 or more errors, it's just terrible.

This PR changes the output, now only not found expected errors and unexpected errors are displayed. Everything else is unneeded and so, isn't displayed.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jun 30, 2016

original (yes, it took me a while to copy/paste):

actual errors (from JSON output): [
    Error {
        line_num: 18,
        kind: Some(
            Error
        ),
        msg: "18:42: 18:48: unknown meta item \'reason\' [E0541]"
    }
   // and every other errors
]

expected errors (from test file): [
    Error {
        line_num: 18,
        kind: Some(
            Error
        ),
        msg: "unknown meta item \'reason\'"
     }
     // and every other expected errors
]

new output:

unexpected errors (from JSON output): [
    Error {
        line_num: 77,
        kind: Some(
            Error
        ),
        msg: "77:3: 77:38: multiple stability levels [E0544]"
    }
]

not found errors (from test file): [
    Error {
        line_num: 78,
        kind: Some(
            Error
        ),
        msg: "multiple stability levels"
    }
]

Do you understand better? The second one only keeps the pertinent information. :)

@sophiajt
Copy link
Contributor

sophiajt commented Jul 1, 2016

LGTM

@alexcrichton
Copy link
Member

@bors: r+ 737d854

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 2, 2016
bors added a commit that referenced this pull request Jul 2, 2016
Rollup of 7 pull requests

- Successful merges: #34531, #34545, #34551, #34566, #34567, #34574, #34583
- Failed merges:
@bors bors merged commit 737d854 into rust-lang:master Jul 2, 2016
@GuillaumeGomez GuillaumeGomez deleted the runtest_improvement branch July 2, 2016 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants