Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trans: Make sure that closures only get translated once. #34728

Merged
merged 1 commit into from
Jul 9, 2016
Merged

trans: Make sure that closures only get translated once. #34728

merged 1 commit into from
Jul 9, 2016

Conversation

michaelwoerister
Copy link
Member

Fixes #34569.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

luqmana
luqmana reviewed Jul 9, 2016
View reviewed changes
src/librustc_trans/closure.rs
};

trans_closure(ccx,
decl,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: formatting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@luqmana
Copy link
Member

luqmana commented Jul 9, 2016

LGTM, r=me with nit fixed.

@michaelwoerister
Copy link
Member Author

@bors r=luqmana

@bors
Copy link
Contributor

bors commented Jul 9, 2016

📌 Commit b732cf4 has been approved by luqmana

@bors
Copy link
Contributor

bors commented Jul 9, 2016

⌛ Testing commit b732cf4 with merge 7323ac4...

bors added a commit that referenced this pull request Jul 9, 2016
@bors
Auto merge of #34728 - michaelwoerister:issue34569, r=luqmana
7323ac4 
trans: Make sure that closures only get translated once.

Fixes #34569.
@bors
Copy link
Contributor

bors commented Jul 9, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild
Approved by: luqmana
Pushing 7323ac4 to master...

@bors bors merged commit b732cf4 into rust-lang:master Jul 9, 2016
@jonas-schievink jonas-schievink mentioned this pull request Jul 17, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michaelwoerister @rust-highfive @luqmana @bors @nikomatsakis