Add method String::insert_str

[murarth]

No description provided.

[rust-highfive]

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

[brson]

The functionality makes sense to me. Is there really no easy way to do this today? cc @rust-lang/libs

[brson]

@murarth Can you please change the stability attribute to 'unstable'? New features mostly don't get stabilized immediately.

[murarth]

This is pretty common functionality whose absence I thought was a bit strange. The signature of insert_str mirrors insert and the name goes along with the push/push_str methods.

This seems to me like a sufficiently small addition not to warrant an RFC, so I thought I'd go ahead and submit it.

The #[stable] attribute on the new method was just to get it to pass make check on my machine. I will gladly change it if that's deemed appropriate.

[murarth]

@brson: Sure, I just didn't know what to put for issue or whether the compiler would accept it without that.

[brson]

@murarth "0" is fine for now. If this PR is accepted then before it's merged you'll need to file a 'tracking' issue on the issue tracker to fill in the real number.

[murarth]

@brson: Okay. It's unstable now.

[BurntSushi]

This seems fine to me. I agree that it's small enough that we probably wouldn't need an RFC for it.

[sfackler]

LGTM

[ollie27]

This is covered by String::splice rust-lang/rfcs#1432.

[alexcrichton]

Ah yeah I was also under the impression that this was going to be functionality implemented through splice that @ollie27 linked to. Perhaps the PR to implement could be revived?

[murarth]

I wasn't aware of that RFC. Even so, splice looks to be a slightly different kind of operation. If I understand correctly, then inserting a string without replacing would look something like a.splice(idx..idx, b), which looks a bit odd.

[alexcrichton]

Yeah it's true that does look a bit odd! We might still have API room to add a function like this, and to me it seems to fit all existing conventions so I'd also be fine layering this on top (although it'd probably use splice as an implementation detail eventually)

[aturon]

I'm likewise happy having this as a convenience on top of splice.

[alexcrichton]

Discussed during libs triage today the decision was to merge, thanks for the PR @murarth!

@bors: r+

[bors]

📌 Commit 0bcf64c has been approved by alexcrichton

[bors]

⌛ Testing commit 0bcf64c with merge 67f0941...

[bors]

💔 Test failed - auto-win-msvc-64-opt

[alexcrichton]

@bors: retry

• Cascading failure on bots when interrupted when performing git operations #34595

On Tue, Jul 19, 2016 at 12:46 PM, bors [email protected] wrote:

💔 Test failed - auto-win-msvc-64-opt
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/4936

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#34771 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95NRWv0XHT0MiKu8iESzlmdl58ApFks5qXSmMgaJpZM4JJ1x-
.

[bors]

⌛ Testing commit 0bcf64c with merge 482a03c...

[bors]

💔 Test failed - auto-win-msvc-64-opt-rustbuild

[alexcrichton]

@bors: retry

• Cascading failure on bots when interrupted when performing git operations #34595

On Tue, Jul 19, 2016 at 9:19 PM, bors [email protected] wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/1822

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#34771 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95N5Rz03tPpQZoHZrYQ9GlVcecAlDks5qXaHKgaJpZM4JJ1x-
.

[bors]

⌛ Testing commit 0bcf64c with merge 44b6d38...

[bors]

💔 Test failed - auto-win-gnu-32-opt-rustbuild

[alexcrichton]

@bors: retry

On Wed, Jul 20, 2016 at 5:40 PM, bors [email protected] wrote:

💔 Test failed - auto-win-gnu-32-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt-rustbuild/builds/1861

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#34771 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95EOEDk87Sfz4yXMXNMkK9T3hotQGks5qXr_2gaJpZM4JJ1x-
.

[bors]

⌛ Testing commit 0bcf64c with merge 6722228...

[bors]

💔 Test failed - auto-linux-64-debug-opt

[alexcrichton]

@bors: retry

sorry for the number of retries...

On Thu, Jul 21, 2016 at 12:21 PM, bors [email protected] wrote:

💔 Test failed - auto-linux-64-debug-opt
https://buildbot.rust-lang.org/builders/auto-linux-64-debug-opt/builds/3189

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
#34771 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95I7ulfxkYyExSanlqzqda1L0nfIvks5qX8a_gaJpZM4JJ1x-
.

[bors]

⌛ Testing commit 0bcf64c with merge d15e265...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-mir, auto-win-msvc-64-opt-rustbuild
Approved by: alexcrichton
Pushing d15e265 to master...

[murarth]

Just curious, will the libs team create a tracking issue for this at some time or am I supposed to file one myself?

[alexcrichton]

Oh oops! Thanks for the reminder @murarth! This actually should have held off on landing until a tracking issue was made, but oh well.

If you want to open a tracking issue and send a PR updating the reference here I'll r+ and tag appropriately.