Update E0116 to new error code format. #35467
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -33,10 +33,13 @@ struct OrphanChecker<'cx, 'tcx:'cx> { | |||
| impl<'cx, 'tcx> OrphanChecker<'cx, 'tcx> { | |||
| fn check_def_id(&self, item: &hir::Item, def_id: DefId) { | |||
| if def_id.krate != LOCAL_CRATE { | |||
| span_err!(self.tcx.sess, item.span, E0116, | |||
| struct_span_err!(self.tcx.sess, item.span, E0116, | |||
| "cannot define inherent `impl` for a type outside of the \ | |||
| crate where the type is defined; define and implement \ | |||
There was a problem hiding this comment.
Can you remove the "; define and implement a trait or new type instead" from the error title?
|
Thanks for the PR! This looks really close. I made a comment on the one part that still needs to be updated. After that, squash down to 1 commit, and I think we'll be ready to go. |
|
Got it! |
|
Looks good! @bors r+ rollup |
|
📌 Commit 03dc484 has been approved by |
Update E0116 to new error code format. Fixes rust-lang#35249 as part of rust-lang#35233. r? @jonathandturner
Fixes #35249 as part of #35233.
r? @jonathandturner