Update error message for E0253 #35512 #35558
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Apologies about the commit message derp! Regarding the CI failure, seems to be do with a docker run: The unit tests all worked however: |
| use foo::MyTrait::do_something; //~ ERROR E0253 | ||
| use foo::MyTrait::do_something; | ||
| //~^ ERROR E0253 | ||
| //~|NOTE not directly importable |
There was a problem hiding this comment.
this should probably be `| NOTE cannot be imported directly", no?
There was a problem hiding this comment.
Updated it now, with a new commit, but in hindsight I wonder if I should have done a commit --amend?, and it might cause a merge conflict? (clicked on the pencil above, and did a browser edit)
(apologies, I have got so used to working via gerrit, and github stumps me).
changed error text
|
@bors r+ rollup |
|
📌 Commit c974749 has been approved by |
Update error message for E0253 rust-lang#35512 Fixes rust-lang#35512. Part of rust-lang#35233.
Update error message for E0253 rust-lang#35512 Fixes rust-lang#35512. Part of rust-lang#35233.
Update error message for E0253 rust-lang#35512 Fixes rust-lang#35512. Part of rust-lang#35233.
Rollup of 30 pull requests - Successful merges: #34941, #35392, #35444, #35447, #35491, #35533, #35539, #35558, #35573, #35574, #35577, #35586, #35588, #35594, #35596, #35597, #35598, #35606, #35611, #35615, #35616, #35620, #35622, #35640, #35643, #35644, #35646, #35647, #35648, #35661 - Failed merges: #35395, #35415
Fixes #35512. Part of #35233.