Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs typo in std::os::unix::net::SocketAddr::is_unnamed #35569

Merged
merged 2 commits into from
Aug 12, 2016
Merged

Fix docs typo in std::os::unix::net::SocketAddr::is_unnamed #35569

merged 2 commits into from
Aug 12, 2016

Conversation

pietroalbini
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

Thanks for this PR! There's some subtlety though: iff is often used as shorthand for "if and only if", which i believe is the case here. Would you mind updating it to spell this out?

@steveklabnik
Copy link
Member

Thank you!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Aug 10, 2016

📌 Commit 907a20c has been approved by steveklabnik

@pietroalbini
Copy link
Member Author

Well, I learned something new today! (I'm not a native speaker)

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 10, 2016
Rollup merge of rust-lang#35569 - pietroalbini:fix-typo, r=steveklabnik
66a0b85 
Fix docs typo in std::os::unix::net::SocketAddr::is_unnamed
@sophiajt sophiajt mentioned this pull request Aug 10, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 11, 2016
Rollup merge of rust-lang#35569 - pietroalbini:fix-typo, r=steveklabnik
0e92c5e 
Fix docs typo in std::os::unix::net::SocketAddr::is_unnamed
@sophiajt sophiajt mentioned this pull request Aug 11, 2016
Merged
bors added a commit that referenced this pull request Aug 11, 2016
@bors
Auto merge of #35592 - jonathandturner:rollup, r=jonathandturner
8787a12 
Rollup of 23 pull requests

- Successful merges: #35279, #35331, #35358, #35375, #35445, #35448, #35482, #35486, #35505, #35528, #35530, #35532, #35536, #35537, #35541, #35552, #35554, #35555, #35557, #35562, #35565, #35569, #35576
- Failed merges: #35395, #35415, #35563
@bors bors merged commit 907a20c into rust-lang:master Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pietroalbini @rust-highfive @steveklabnik @bors @aturon