Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Stabilize APIs for the 1.12 release #35607

Merged
merged 1 commit into from
Aug 20, 2016

Conversation

alexcrichton
Copy link
Member

Stabilized

  • Cell::as_ptr
  • RefCell::as_ptr
  • IpAddr::is_{unspecified,loopback,multicast}
  • Ipv6Addr::octets
  • LinkedList::contains
  • VecDeque::contains
  • ExitStatusExt::from_raw - both on Unix and Windows
  • Receiver::recv_timeout
  • RecvTimeoutError
  • BinaryHeap::peek_mut
  • PeekMut
  • iter::Product
  • iter::Sum
  • OccupiedEntry::remove_entry
  • VacantEntry::into_key

Deprecated

  • Cell::as_unsafe_cell
  • RefCell::as_unsafe_cell
  • OccupiedEntry::remove_pair

Closes #27708
cc #27709
Closes #32313
Closes #32630
Closes #32713
Closes #34029
Closes #34392
Closes #34285
Closes #34529

@alexcrichton
Copy link
Member Author

r? @aturon

cc @rust-lang/libs

@rust-highfive rust-highfive assigned aturon and unassigned brson Aug 11, 2016
@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 17, 2016
@@ -86,8 +85,6 @@ impl IpAddr {
/// Returns true if the address appears to be globally routable ([IPv4], [IPv6]).
/// [IPv4]: ../../std/net/struct.Ipv4Addr.html#method.is_global
/// [IPv6]: ../../std/net/struct.Ipv6Addr.html#method.is_global
#[unstable(feature="ip", issue="27709",
reason="recently added and depends on unstable Ip{v4,v6}Addr.is_global()")]
pub fn is_global(&self) -> bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do this and is_documentation have no tag at all now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah this file is tagged with #![unstable], so it inherits from that.

@brson
Copy link
Contributor

brson commented Aug 17, 2016

r=me assuming the question of the disappeared tags is resolved.

@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Aug 18, 2016

📌 Commit 7173794 has been approved by brson

@bors
Copy link
Contributor

bors commented Aug 18, 2016

⌛ Testing commit 7173794 with merge 7f38beb...

bors added a commit that referenced this pull request Aug 18, 2016
std: Stabilize APIs for the 1.12 release

Stabilized

* `Cell::as_ptr`
* `RefCell::as_ptr`
* `IpAddr::is_{unspecified,loopback,multicast}`
* `Ipv6Addr::octets`
* `LinkedList::contains`
* `VecDeque::contains`
* `ExitStatusExt::from_raw` - both on Unix and Windows
* `Receiver::recv_timeout`
* `RecvTimeoutError`
* `BinaryHeap::peek_mut`
* `PeekMut`
* `iter::Product`
* `iter::Sum`
* `OccupiedEntry::remove_entry`
* `VacantEntry::into_key`

Deprecated

* `Cell::as_unsafe_cell`
* `RefCell::as_unsafe_cell`
* `OccupiedEntry::remove_pair`

Closes #27708
cc #27709
Closes #32313
Closes #32630
Closes #32713
Closes #34029
Closes #34392
Closes #34285
Closes #34529
@bors
Copy link
Contributor

bors commented Aug 18, 2016

💔 Test failed - auto-mac-64-opt-rustbuild

Stabilized

* `Cell::as_ptr`
* `RefCell::as_ptr`
* `IpAddr::is_{unspecified,loopback,multicast}`
* `Ipv6Addr::octets`
* `LinkedList::contains`
* `VecDeque::contains`
* `ExitStatusExt::from_raw` - both on Unix and Windows
* `Receiver::recv_timeout`
* `RecvTimeoutError`
* `BinaryHeap::peek_mut`
* `PeekMut`
* `iter::Product`
* `iter::Sum`
* `OccupiedEntry::remove_entry`
* `VacantEntry::into_key`

Deprecated

* `Cell::as_unsafe_cell`
* `RefCell::as_unsafe_cell`
* `OccupiedEntry::remove_pair`

Closes rust-lang#27708
cc rust-lang#27709
Closes rust-lang#32313
Closes rust-lang#32630
Closes rust-lang#32713
Closes rust-lang#34029
Closes rust-lang#34392
Closes rust-lang#34285
Closes rust-lang#34529
@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Aug 19, 2016

📌 Commit afeeade has been approved by brson

@bors
Copy link
Contributor

bors commented Aug 20, 2016

⌛ Testing commit afeeade with merge 99867ee...

bors added a commit that referenced this pull request Aug 20, 2016
std: Stabilize APIs for the 1.12 release

Stabilized

* `Cell::as_ptr`
* `RefCell::as_ptr`
* `IpAddr::is_{unspecified,loopback,multicast}`
* `Ipv6Addr::octets`
* `LinkedList::contains`
* `VecDeque::contains`
* `ExitStatusExt::from_raw` - both on Unix and Windows
* `Receiver::recv_timeout`
* `RecvTimeoutError`
* `BinaryHeap::peek_mut`
* `PeekMut`
* `iter::Product`
* `iter::Sum`
* `OccupiedEntry::remove_entry`
* `VacantEntry::into_key`

Deprecated

* `Cell::as_unsafe_cell`
* `RefCell::as_unsafe_cell`
* `OccupiedEntry::remove_pair`

Closes #27708
cc #27709
Closes #32313
Closes #32630
Closes #32713
Closes #34029
Closes #34392
Closes #34285
Closes #34529
@bors bors merged commit afeeade into rust-lang:master Aug 20, 2016
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 22, 2016
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 24, 2016
@alexcrichton alexcrichton deleted the stabilize-1.12 branch August 26, 2016 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants