Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure metadata encoder to track deps precisely #35684

Merged
merged 22 commits into from
Aug 18, 2016
Merged

Restructure metadata encoder to track deps precisely #35684

merged 22 commits into from
Aug 18, 2016

Commits on Aug 17, 2016

  1. move CrateIndex into its own module

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    b5fa8ab View commit details
    Browse the repository at this point in the history

  2. rename CrateIndex to IndexBuilder

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    85ac63e View commit details
    Browse the repository at this point in the history

  3. store ecx, not dep-graph

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    25bb51d View commit details
    Browse the repository at this point in the history

  4. put ecx into IndexBuilder so we don't have to pass

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    92f269e View commit details
    Browse the repository at this point in the history

  5. move free encode fns into methods of IndexBuilder

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    b2c7922 View commit details
    Browse the repository at this point in the history

  6. introduce Deref/DerefMut to model subtype rel 

    The idea is that ItemContentBuilder is a base-type of IndexBuilder.
    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    6b76932 View commit details
    Browse the repository at this point in the history

  7. make record take a closure

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    baccdc0 View commit details
    Browse the repository at this point in the history

  8. move rbml_w into the self struct

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    d49e1a9 View commit details
    Browse the repository at this point in the history

  9. separate main items from addl items in metadata

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    6277b1f View commit details
    Browse the repository at this point in the history

  10. pull out the record call for encode_info_for_item

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    5166682 View commit details
    Browse the repository at this point in the history

  11. pull out code for encoding enum variants

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    f351963 View commit details
    Browse the repository at this point in the history

  12. pull out encode_field

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    c716ad8 View commit details
    Browse the repository at this point in the history

  13. don't pass extra state fo encode_struct_ctor

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    9afcd77 View commit details
    Browse the repository at this point in the history

  14. pull out call to record for impl items

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    8dc8151 View commit details
    Browse the repository at this point in the history

  15. extract encode_info_for_trait_item into method

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    8c4a224 View commit details
    Browse the repository at this point in the history

  16. extract two more record calls

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    c0c8ab9 View commit details
    Browse the repository at this point in the history

  17. change callback for expr/type to a fn pointer 

    The idea is that, this way, we can cleanly isolate ALL state that is
being passed, since it goes as an argument to the fn pointer.
    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    00e699f View commit details
    Browse the repository at this point in the history

  18. create a trait to ensure that data is tracked 

    Also write a comment explaining the system.
    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    f3990fe View commit details
    Browse the repository at this point in the history

  19. pacify the mercilous tidy

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    1a91e67 View commit details
    Browse the repository at this point in the history

  20. Add a comment, remove Deref/DerefMut 

    The comment explains the `index-builder` pattern. We no longer need the
`Deref/DerefMut` relationship, and it seems nicer without it.
    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    9daea5b View commit details
    Browse the repository at this point in the history

  21. remove usize: DepGraphRead and add Untracked 

    The idea is that a `usize` is sort of ambiguous: in this case, it
represents indices that do not need tracking, but it could as easily be
some data read out from a tracked location, and hence represent tracked
data. Therefore, we add an `Untracked` type that lets user assert
that value is not tracked.

Also correct various typos.
    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    6b33f47 View commit details
    Browse the repository at this point in the history

  22. remove seemingly unnecessary call to encode_predicates

    @nikomatsakis
    nikomatsakis committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    37d974f View commit details
    Browse the repository at this point in the history