E0435, E0437 & E0438 New Error Format

[shyamsundarb-arch]

Part of #35801 , #35802 and #35803
r? @GuillaumeGomez

Hi! Please review the changes.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[sophiajt]

Thanks for the PR (and for squashing)

Have you compiled and tested this PR? Our tester found that this code does not yet compile:

src/librustc_resolve/lib.rs:254:13: 260:95 error: mismatched types [E0308]

src/librustc_resolve/lib.rs:254             struct_span_err!(resolver.session,

                                            ^

src/librustc_resolve/lib.rs:254:13: 260:95 help: run `rustc --explain E0308` to see a detailed explanation

src/librustc_resolve/lib.rs:254:13: 260:95 note: expected type `errors::DiagnosticBuilder<'a>`

src/librustc_resolve/lib.rs:254:13: 260:95 note:    found type `()`

src/librustc_resolve/lib.rs:263:13: 269:95 error: mismatched types [E0308]

src/librustc_resolve/lib.rs:263             struct_span_err!(resolver.session,

                                            ^

src/librustc_resolve/lib.rs:263:13: 269:95 help: run `rustc --explain E0308` to see a detailed explanation

src/librustc_resolve/lib.rs:263:13: 269:95 note: expected type `errors::DiagnosticBuilder<'a>`

src/librustc_resolve/lib.rs:263:13: 269:95 note:    found type `()`

src/librustc_resolve/lib.rs:443:13: 447:99 error: mismatched types [E0308]

src/librustc_resolve/lib.rs:443             struct_span_err!(resolver.session,

                                            ^

src/librustc_resolve/lib.rs:443:13: 447:99 help: run `rustc --explain E0308` to see a detailed explanation

src/librustc_resolve/lib.rs:443:13: 447:99 note: expected type `errors::DiagnosticBuilder<'a>`

src/librustc_resolve/lib.rs:443:13: 447:99 note:    found type `()`

error: aborting due to 3 previous errors

You may want to have another look. Just ping me or @GuillaumeGomez when you're ready.

[shyamsundarb-arch]

@jonathandturner Hi. Thanks for your patience with me. I have fixed the cause of errors. Hopefully it should get through.

[GuillaumeGomez]

It doesn't coompile.

[shyamsundarb-arch]

Hopefully I compiled in local with the previous errors rectified. It should compile.

[shyamsundarb-arch]

@GuillaumeGomez Kindly review changes.

[GuillaumeGomez]

Thanks!

@bors: r+ rollup

[bors]

📌 Commit 738b91e has been approved by GuillaumeGomez