Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various refactorings in the rustdoc module. #35867

Merged
merged 9 commits into from
Aug 25, 2016
Merged

Various refactorings in the rustdoc module. #35867

merged 9 commits into from
Aug 25, 2016

Conversation

frewsxcv
Copy link
Member

No description provided.

@frewsxcv
Copy link
Member Author

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Aug 24, 2016

📌 Commit 6e42b8e has been approved by alexcrichton

eddyb
eddyb reviewed Aug 25, 2016
View reviewed changes
src/librustdoc/html/format.rs
&format!("&{}{}[{}]", lt, m, **bt)),
_ => {
primitive_link(f, clean::Slice, &format!("&{}{}[", lt, m))?;
primitive_link(f, PrimitiveType::Slice, &format!("&{}{}[", lt, m))?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails tidy, line too long.

@eddyb
Copy link
Member

eddyb commented Aug 25, 2016

@bors r-

@frewsxcv
Copy link
Member Author

make tidy fixed in the latest force push.

@eddyb
Copy link
Member

eddyb commented Aug 25, 2016

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Aug 25, 2016

📌 Commit 42e8ac8 has been approved by alexcrichton

@Manishearth Manishearth mentioned this pull request Aug 25, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 25, 2016
@Manishearth
Rollup merge of rust-lang#35867 - frewsxcv:rustdoc-cleanup, r=alexcri…
71fb594 
…chton

Various refactorings in the rustdoc module.

None
bors added a commit that referenced this pull request Aug 25, 2016
@bors
Auto merge of #35979 - Manishearth:rollup, r=Manishearth
05fb797 
Rollup of 6 pull requests

- Successful merges: #35238, #35867, #35885, #35916, #35947, #35955
- Failed merges:
Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 25, 2016
@Manishearth
Rollup merge of rust-lang#35867 - frewsxcv:rustdoc-cleanup, r=alexcri…
5e69622 
…chton

Various refactorings in the rustdoc module.

None
bors added a commit that referenced this pull request Aug 25, 2016
@bors
Auto merge of #35979 - Manishearth:rollup, r=Manishearth
17a2be8 
Rollup of 6 pull requests

- Successful merges: #35238, #35867, #35885, #35916, #35947, #35955
- Failed merges:
@bors bors merged commit 42e8ac8 into rust-lang:master Aug 25, 2016
@frewsxcv frewsxcv deleted the rustdoc-cleanup branch August 25, 2016 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frewsxcv @alexcrichton @bors @eddyb