-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load extern crates in resolve
#36525
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jseyfried
force-pushed
the
load_crates_in_resolve
branch
from
September 16, 2016 03:29
e920f4e
to
4ea885b
Compare
This is groundwork for macro modularization (cc @nrc). |
☔ The latest upstream changes (presumably #36551) made this pull request unmergeable. Please resolve the merge conflicts. |
jseyfried
force-pushed
the
load_crates_in_resolve
branch
from
September 22, 2016 07:11
4ea885b
to
cc174de
Compare
☔ The latest upstream changes (presumably #36573) made this pull request unmergeable. Please resolve the merge conflicts. |
jseyfried
force-pushed
the
load_crates_in_resolve
branch
from
September 23, 2016 06:36
cc174de
to
7b5c59e
Compare
@bors r+ |
📌 Commit 7b5c59e has been approved by |
bors
added a commit
that referenced
this pull request
Sep 23, 2016
Load extern crates in `resolve` This PR loads `extern crate`s in `resolve`'s `BuildReducedGraphVistor`. r? @nikomatsakis
⌛ Testing commit 7b5c59e with merge ee959a8... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR loads
extern crate
s inresolve
'sBuildReducedGraphVistor
.It is groundwork for macro modularization (cc #35896).
r? @nikomatsakis