Document init of HashSet/HashMap from vector #36740

frehberg · 2016-09-26T11:44:54Z

No description provided.

rust-highfive · 2016-09-26T11:45:02Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

petrochenkov · 2016-09-26T11:47:59Z

src/libstd/collections/hash/map.rs

+///     [ ("Norway", 100),
+///       ("Denmark", 50),
+///       ("Iceland", 10) ]
+///       .iter().map(|&x| x).collect();


.cloned() can be used instead of .map(|&x| x)

comment merged in

jonas-schievink · 2016-09-26T15:54:48Z

src/libstd/collections/hash/map.rs

@@ -335,6 +335,20 @@ fn test_resize_policy() {
 ///     println!("{:?} has {} hp", viking, health);
 /// }
 /// ```
+/// A HashMap with fixed list of elements can be initialized from vector:


"from an array"

comments have been merged in

jonas-schievink · 2016-09-26T15:55:09Z

src/libstd/collections/hash/set.rs

@@ -100,6 +100,18 @@ const INITIAL_CAPACITY: usize = 32;
 ///     println!("{:?}", x);
 /// }
 /// ```
+/// HashSet with fixed list of elements can be initialized from vector:


"from an array"

steveklabnik

Some small nits!

steveklabnik · 2016-09-26T19:42:02Z

src/libstd/collections/hash/map.rs

+///
+/// fn main() {
+///     let timber_resources: HashMap<&str, i32> =
+///     [ ("Norway", 100),


the space between [( should go away

steveklabnik · 2016-09-26T19:42:15Z

src/libstd/collections/hash/map.rs

+///     let timber_resources: HashMap<&str, i32> =
+///     [ ("Norway", 100),
+///       ("Denmark", 50),
+///       ("Iceland", 10) ]


steveklabnik · 2016-09-26T19:42:27Z

src/libstd/collections/hash/map.rs

+///     [ ("Norway", 100),
+///       ("Denmark", 50),
+///       ("Iceland", 10) ]
+///       .iter().cloned().collect();


does into_iter work here, rather than iter.cloned()?

no, I tried

steveklabnik · 2016-09-26T19:42:48Z

src/libstd/collections/hash/set.rs

@@ -100,6 +100,18 @@ const INITIAL_CAPACITY: usize = 32;
 ///     println!("{:?}", x);
 /// }
 /// ```
+/// HashSet with fixed list of elements can be initialized from an array:


can you put a newline above and below this line, please?

steveklabnik · 2016-09-26T19:43:00Z

src/libstd/collections/hash/map.rs

@@ -335,6 +335,20 @@ fn test_resize_policy() {
 ///     println!("{:?} has {} hp", viking, health);
 /// }
 /// ```
+/// A HashMap with fixed list of elements can be initialized from an array:


can you put a newline before and after this line please?

frehberg · 2016-09-27T14:01:22Z

all comments merged in

steveklabnik · 2016-09-27T14:05:58Z

@bors: r+ rollup

thank you!

bors · 2016-09-27T14:05:59Z

📌 Commit f953d25 has been approved by steveklabnik

frehberg · 2016-09-28T07:24:55Z

Sadly I don't have permissions to merge :( Will anybody merge this in now?

steveklabnik · 2016-09-28T15:37:13Z

@frehberg @bors will do it automatically, you just have to wait. :) once we say r+, it's in the queue: https://buildbot.rust-lang.org/homu/queue/rust

Document init of HashSet/HashMap from vector

Rollup of 11 pull requests - Successful merges: #36376, #36672, #36740, #36757, #36765, #36769, #36782, #36783, #36784, #36795, #36796 - Failed merges:

Document init of HashSet/HashMap from vector

aed99c8

rust-highfive assigned aturon Sep 26, 2016

petrochenkov reviewed Sep 26, 2016

View reviewed changes

frehberg added 2 commits September 26, 2016 16:00

Update map.rs

bd80e7b

Update set.rs

3551008

jonas-schievink reviewed Sep 26, 2016

View reviewed changes

frehberg added 2 commits September 26, 2016 18:15

Update map.rs

ba84d4f

Update set.rs

6c4616c

steveklabnik suggested changes Sep 26, 2016

View reviewed changes

frehberg added 2 commits September 27, 2016 10:31

Update map.rs

81c47d5

Update set.rs

f953d25

steveklabnik approved these changes Sep 27, 2016

View reviewed changes

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 28, 2016

Rollup merge of rust-lang#36740 - frehberg:apidoc, r=steveklabnik

4676bb0

Document init of HashSet/HashMap from vector

sophiajt mentioned this pull request Sep 28, 2016

Rollup of 11 pull requests #36805

Merged

bors added a commit that referenced this pull request Sep 28, 2016

Auto merge of #36805 - jonathandturner:rollup, r=jonathandturner

86affcd

Rollup of 11 pull requests - Successful merges: #36376, #36672, #36740, #36757, #36765, #36769, #36782, #36783, #36784, #36795, #36796 - Failed merges:

bors merged commit f953d25 into rust-lang:master Sep 29, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Document init of HashSet/HashMap from vector #36740

Document init of HashSet/HashMap from vector #36740

frehberg commented Sep 26, 2016

rust-highfive commented Sep 26, 2016

petrochenkov Sep 26, 2016

frehberg Sep 26, 2016

jonas-schievink Sep 26, 2016

frehberg Sep 26, 2016

jonas-schievink Sep 26, 2016

steveklabnik left a comment

steveklabnik Sep 26, 2016

frehberg Sep 27, 2016

steveklabnik Sep 26, 2016

frehberg Sep 27, 2016

steveklabnik Sep 26, 2016

frehberg Sep 27, 2016

steveklabnik Sep 26, 2016

frehberg Sep 27, 2016

steveklabnik Sep 26, 2016

frehberg Sep 27, 2016

frehberg commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

bors commented Sep 27, 2016

frehberg commented Sep 28, 2016

steveklabnik commented Sep 28, 2016

Document init of HashSet/HashMap from vector #36740

Document init of HashSet/HashMap from vector #36740

Conversation

frehberg commented Sep 26, 2016

rust-highfive commented Sep 26, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steveklabnik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frehberg commented Sep 27, 2016

steveklabnik commented Sep 27, 2016

bors commented Sep 27, 2016

frehberg commented Sep 28, 2016

steveklabnik commented Sep 28, 2016