Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc: Use a special filename for macros 1.1 #36776

Merged
merged 1 commit into from
Sep 28, 2016

Conversation

alexcrichton
Copy link
Member

This "special filename" is surrounded by <> to ensure that
FileMap::is_real_file returns false. This way the "files" parsed here aren't
emitted as dep info .d files and don't confuse Cargo about non-existent files.

Closes #36625

@rust-highfive
Copy link
Collaborator

r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

This "special filename" is surrounded by `<>` to ensure that
`FileMap::is_real_file` returns `false`. This way the "files" parsed here aren't
emitted as dep info `.d` files and don't confuse Cargo about non-existent files.

Closes rust-lang#36625
@nrc
Copy link
Member

nrc commented Sep 27, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 27, 2016

📌 Commit 20a71b2 has been approved by nrc

@bors
Copy link
Contributor

bors commented Sep 28, 2016

⌛ Testing commit 20a71b2 with merge 6d49ecc...

@bors
Copy link
Contributor

bors commented Sep 28, 2016

💔 Test failed - auto-win-gnu-64-opt

@alexcrichton
Copy link
Member Author

@bors: reetry

On Tue, Sep 27, 2016 at 7:37 PM, bors [email protected] wrote:

💔 Test failed - auto-win-gnu-64-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-64-opt/builds/5722


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#36776 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95MGaV4P07x1Mp3EmuHa_n58Ujpsdks5qudLvgaJpZM4KH_iA
.

@alexcrichton
Copy link
Member Author

@bors: retry

On Tue, Sep 27, 2016 at 7:53 PM, Alex Crichton [email protected]
wrote:

@bors: reetry

On Tue, Sep 27, 2016 at 7:37 PM, bors [email protected] wrote:

💔 Test failed - auto-win-gnu-64-opt
https://buildbot.rust-lang.org/builders/auto-win-gnu-64-opt/builds/5722


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#36776 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD95MGaV4P07x1Mp3EmuHa_n58Ujpsdks5qudLvgaJpZM4KH_iA
.

@bors
Copy link
Contributor

bors commented Sep 28, 2016

⌛ Testing commit 20a71b2 with merge 1c7d25a...

@alexcrichton
Copy link
Member Author

@bors: retry force clean

@bors
Copy link
Contributor

bors commented Sep 28, 2016

⌛ Testing commit 20a71b2 with merge 755516b...

bors added a commit that referenced this pull request Sep 28, 2016
rustc: Use a special filename for macros 1.1

This "special filename" is surrounded by `<>` to ensure that
`FileMap::is_real_file` returns `false`. This way the "files" parsed here aren't
emitted as dep info `.d` files and don't confuse Cargo about non-existent files.

Closes #36625
@bors bors merged commit 20a71b2 into rust-lang:master Sep 28, 2016
@alexcrichton alexcrichton deleted the rustc-macro-dep-files branch October 6, 2016 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants