Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update E0220 error format #36862

Merged
merged 1 commit into from
Oct 2, 2016
Merged

Update E0220 error format #36862

merged 1 commit into from
Oct 2, 2016

Conversation

chamoysvoice
Copy link
Contributor

@jonathandturner
Part of #35233 .
Fixes #35385.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 30, 2016

📌 Commit 08375a8 has been approved by jonathandturner

@TimNN
Copy link
Contributor

TimNN commented Sep 30, 2016

There are some tidy failures:

/build/src/test/compile-fail/E0220.rs:16: tab character
/build/src/test/compile-fail/E0220.rs:18: tab character
/build/src/test/compile-fail/E0220.rs:18: trailing whitespace
/build/src/librustc_typeck/astconv.rs:1248: tab character
/build/src/librustc_typeck/astconv.rs:1249: tab character

@sophiajt
Copy link
Contributor

@bors r-

Pulling it out to deal with the tidy fixes.

@chamoysvoice - you can run tidy and fix the errors using:

python src/bootstrap/bootstrap.py --stage 1 --step check-tidy

It's like running the test suite, but checks against code following the style guidelines.

squash! Update E0220 error format

Update Error E0220 to new format
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Oct 2, 2016

📌 Commit f4fdf81 has been approved by GuillaumeGomez

@bors
Copy link
Contributor

bors commented Oct 2, 2016

⌛ Testing commit f4fdf81 with merge 791fb77...

bors added a commit that referenced this pull request Oct 2, 2016
@bors bors merged commit f4fdf81 into rust-lang:master Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants