rustc: Try again to disable NEON on armv7 linux #36933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 56a7db2 has been approved by |
parched
reviewed
Oct 4, 2016
| @@ -13,7 +13,7 @@ use target::{Target, TargetOptions, TargetResult}; | |||
| pub fn target() -> TargetResult { | |||
| let base = super::linux_base::opts(); | |||
| Ok(Target { | |||
| llvm_target: "armv7-unknown-linux-gnueabihf".to_string(), | |||
| llvm_target: "arm-unknown-linux-gnueabihf".to_string(), | |||
There was a problem hiding this comment.
Not sure if it matters, but you lose the Tag_CPU_arch_profile: Application attribute this way, but you could add it back with +aclass.
IMO armv7-unknown-linux-gnueabihf with -neon,+vfp3,+d16 is all that is needed here.
parched
suggested changes
Oct 4, 2016
| @@ -13,7 +13,7 @@ use target::{Target, TargetOptions, TargetResult}; | |||
| pub fn target() -> TargetResult { | |||
| let base = super::linux_base::opts(); | |||
| Ok(Target { | |||
| llvm_target: "armv7-unknown-linux-gnueabihf".to_string(), | |||
| llvm_target: "arm-unknown-linux-gnueabihf".to_string(), | |||
This is a follow-up to rust-lang#35814 which apparently didn't disable it hard enough. It looks like LLVM's default armv7 target enables NEON so we'd otherwise have to pass `-neon`, but we're already enabling armv7 with `+v7` supposedly, so let's try just telling LLVM that the armv7 target is arm and then enable features selectively. Closes rust-lang#36913
alexcrichton
force-pushed
the
less-neon-again
branch
from
56a7db2
to
4625642
Compare
|
@bors: r=eddyb |
|
📌 Commit 4625642 has been approved by |
parched
reviewed
Oct 4, 2016
|
⌛ Testing commit 4625642 with merge 1a41928... |
bors
added a commit
that referenced
this pull request
Oct 4, 2016
rustc: Try again to disable NEON on armv7 linux This is a follow-up to #35814 which apparently didn't disable it hard enough. It looks like LLVM's default armv7 target enables NEON so we'd otherwise have to pass `-neon`, but we're already enabling armv7 with `+v7` supposedly, so let's try just telling LLVM that the armv7 target is arm and then enable features selectively. Closes #36913
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #35814 which apparently didn't disable it hard enough. It
looks like LLVM's default armv7 target enables NEON so we'd otherwise have to
pass
-neon, but we're already enabling armv7 with+v7supposedly, so let'stry just telling LLVM that the armv7 target is arm and then enable features
selectively.
Closes #36913