save-analysis: change imports to carry a ref id rather than their own… #37460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit c751c08 has been approved by |
| @@ -157,7 +157,7 @@ impl From<UseData> for Import { | |||
| fn from(data: UseData) -> Import { | |||
| Import { | |||
| kind: ImportKind::Use, | |||
| id: From::from(data.id), | |||
| ref_id: data.mod_id.map(|id| From::from(id)), | |||
There was a problem hiding this comment.
Why From::from instead of Id::from? I find this ambiguous. Is it intended?
bors
added a commit
that referenced
this pull request
Oct 31, 2016
save-analysis: change imports to carry a ref id rather than their own… … node id To make jump to def for imports work r? @eddyb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… node id
To make jump to def for imports work
r? @eddyb