Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instantiate closures on demand #37797

Merged
merged 1 commit into from
Nov 19, 2016
Merged

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Nov 16, 2016

this should fix compilation with -C codegen-units=4 - tested locally
with RUSTFLAGS='-C codegen-units=4' ../x.py test

r? @michaelwoerister

@michaelwoerister
Copy link
Member

@bors r+

Thanks, @arielb1!
I still think though that trans::callee::get_fn() should be fixed so that we have the option of not having a copy of closures in the using codegen unit.

@bors
Copy link
Contributor

bors commented Nov 16, 2016

📌 Commit 52f7f13 has been approved by michaelwoerister

@arielb1
Copy link
Contributor Author

arielb1 commented Nov 16, 2016

@bors r=michaelwoerister

@bors
Copy link
Contributor

bors commented Nov 16, 2016

📌 Commit 01fe235 has been approved by michaelwoerister

@bors
Copy link
Contributor

bors commented Nov 18, 2016

☔ The latest upstream changes (presumably #37660) made this pull request unmergeable. Please resolve the merge conflicts.

this should fix compilation with `-C codegen-units=4` - tested locally
with `RUSTFLAGS='-C codegen-units=4' ../x.py test`
@arielb1
Copy link
Contributor Author

arielb1 commented Nov 18, 2016

@bors r=michaelwoerister

@bors
Copy link
Contributor

bors commented Nov 18, 2016

📌 Commit 4fc02f6 has been approved by michaelwoerister

@bors
Copy link
Contributor

bors commented Nov 19, 2016

⌛ Testing commit 4fc02f6 with merge aa97daf...

bors added a commit that referenced this pull request Nov 19, 2016
instantiate closures on demand

this should fix compilation with `-C codegen-units=4` - tested locally
with `RUSTFLAGS='-C codegen-units=4' ../x.py test`

r? @michaelwoerister
@bors bors merged commit 4fc02f6 into rust-lang:master Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants