Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing examples in SocketAddr #37880

Merged
merged 1 commit into from
Nov 20, 2016
Merged

Add missing examples in SocketAddr #37880

merged 1 commit into from
Nov 20, 2016

Conversation

GuillaumeGomez
Copy link
Member

@frewsxcv
Copy link
Member

@bors r+ rollup

1 similar comment
@frewsxcv
Copy link
Member

@bors r+ rollup

@eddyb
Copy link
Member

eddyb commented Nov 19, 2016

@bors r=frewsxcv rollup

@bors
Copy link
Contributor

bors commented Nov 19, 2016

📌 Commit f8245c6 has been approved by frewsxcv

@frewsxcv
Copy link
Member

@bors r-

frewsxcv
frewsxcv reviewed Nov 19, 2016
View reviewed changes
src/libstd/net/addr.rs
///
/// use std::net::{IpAddr, Ipv6Addr, SocketAddr};
///
/// fn main() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a closing brace.

@eddyb
Copy link
Member

eddyb commented Nov 19, 2016

@bors r-

@GuillaumeGomez
Copy link
Member Author

Updated.

@frewsxcv
Copy link
Member

@bors r+ rollup

@GuillaumeGomez
Copy link
Member Author

@bors: r=frewsxcv

@bors
Copy link
Contributor

bors commented Nov 20, 2016

📌 Commit bf78ef3 has been approved by frewsxcv

@GuillaumeGomez
Copy link
Member Author

@bors: rollup

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 20, 2016
@GuillaumeGomez
Rollup merge of rust-lang#37880 - GuillaumeGomez:socket-4-doc, r=frew…
5ca9fa4 
…sxcv

Add missing examples in SocketAddr

r? @frewsxcv
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 20, 2016
Merged
bors added a commit that referenced this pull request Nov 20, 2016
@bors
Auto merge of #37896 - GuillaumeGomez:rollup, r=GuillaumeGomez
fb12219 
Rollup of 8 pull requests

- Successful merges: #37835, #37840, #37841, #37848, #37876, #37880, #37881, #37882
- Failed merges:
@bors bors merged commit bf78ef3 into rust-lang:master Nov 20, 2016
@GuillaumeGomez GuillaumeGomez deleted the socket-4-doc branch November 21, 2016 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv approved these changes

Assignees

@frewsxcv frewsxcv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @frewsxcv @eddyb @bors